Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(proto): update zip and remove unused prost_type dep #82

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

lklimek
Copy link
Collaborator

@lklimek lklimek commented Jun 26, 2024

Issue being fixed or feature implemented

  • very old version of zip crate in use by proto-compiler
  • unused prost_types in use by proto

What was done?

update zip t 2.1.3, remove prost_types

How Has This Been Tested?

GHA

cargo check --no-default-features
cargo check --no-default-features -F grpc
cargo check --no-default-features -F std

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@lklimek lklimek added this to the 1.0 milestone Jun 26, 2024
@lklimek lklimek modified the milestones: 1.0, 1.2 Jul 25, 2024
@shumkov shumkov merged commit 7fca4fd into master Jul 25, 2024
12 checks passed
@shumkov shumkov deleted the build/unused-deps branch July 25, 2024 11:29
@lklimek lklimek modified the milestones: 1.2, 1.1 Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants