-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): enforce tonic >= 0.12.3 and update other dependencies #116
Conversation
WalkthroughThe changes in this pull request involve updates to the Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
abci/tests/kvstore.rs (1)
68-71
: LGTM! Consider enhancing the debug message.The changes improve error handling clarity by explicitly capturing and logging the result before assertion. This makes debugging easier when the test fails.
Consider making the debug message more descriptive:
- tracing::debug!(?next_client, "next client"); + tracing::debug!(?next_client, "Server next_client() result");
Issue being fixed or feature implemented
RUSTSEC-2024-0376: Remotely exploitable Denial of Service in Tonic
#2199
What was done?
Enforced Tonic 0.12.3 as minimal version.
How Has This Been Tested?
GHA
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only
Summary by CodeRabbit
tonic-build
dependency to version0.12.3
for improved stability.tonic
dependency to version0.12.3
for enhanced performance and potential bug fixes.test_kvstore
function by capturing the client retrieval result in a variable for better debugging.