Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): enforce tonic >= 0.12.3 and update other dependencies #116

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

lklimek
Copy link
Collaborator

@lklimek lklimek commented Nov 27, 2024

Issue being fixed or feature implemented

RUSTSEC-2024-0376: Remotely exploitable Denial of Service in Tonic
#2199

What was done?

Enforced Tonic 0.12.3 as minimal version.

How Has This Been Tested?

GHA

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Summary by CodeRabbit

  • Bug Fixes
    • Updated the tonic-build dependency to version 0.12.3 for improved stability.
    • Updated the tonic dependency to version 0.12.3 for enhanced performance and potential bug fixes.
  • Tests
    • Enhanced the clarity of the test_kvstore function by capturing the client retrieval result in a variable for better debugging.

Copy link
Contributor

coderabbitai bot commented Nov 27, 2024

Walkthrough

The changes in this pull request involve updates to the Cargo.toml files for two packages: tenderdash-proto-compiler and tenderdash-proto. The primary modification is the version update of the tonic and tonic-build dependencies from 0.12 to 0.12.3. No other dependencies or package configurations were altered, ensuring the overall structure of both packages remains unchanged.

Changes

File Change Summary
proto-compiler/Cargo.toml Updated tonic-build dependency version from 0.12 to 0.12.3.
proto/Cargo.toml Updated tonic dependency version from 0.12 to 0.12.3.
abci/tests/kvstore.rs Modified test_kvstore to capture server.next_client() result in next_client and updated assertion for clarity.

Possibly related PRs

Suggested reviewers

  • shumkov
  • QuantumExplorer

Poem

🐰 In the meadow, changes bloom,
Tonic's tune, a brighter room.
From 0.12 to 0.12.3,
Hopping forward, oh so free!
Dependencies dance, a joyful spree! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
abci/tests/kvstore.rs (1)

68-71: LGTM! Consider enhancing the debug message.

The changes improve error handling clarity by explicitly capturing and logging the result before assertion. This makes debugging easier when the test fails.

Consider making the debug message more descriptive:

-    tracing::debug!(?next_client, "next client");
+    tracing::debug!(?next_client, "Server next_client() result");
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between c75eef9 and ffab273.

📒 Files selected for processing (1)
  • abci/tests/kvstore.rs (1 hunks)

@lklimek lklimek merged commit 36999a4 into develop Nov 28, 2024
10 checks passed
@lklimek lklimek deleted the deps/tokio branch November 28, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants