Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: use cargo binstall to speed up builds #2321
build: use cargo binstall to speed up builds #2321
Changes from 25 commits
24177fa
dacc6db
306b86c
99fe5fa
cee3098
0d3e091
e421514
3d941ec
4bc0a65
dc48827
cafda11
b86f4e0
ae97f47
48cca1a
5c80069
fc0082d
d4c2f7d
88d3596
681bf72
1ac8d3b
fa4cf99
6584fae
8c880aa
113e695
6e02f6a
e395f2e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Improve error handling in cargo-binstall installation
The installation script should verify the successful installation of cargo-binstall before removing the binary and should handle potential network failures.
📝 Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Add error handling for binary copy operation
The copy operation of the built binary should be verified to ensure the file exists and the copy was successful.
📝 Committable suggestion