-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: query block count per Evonode proposed in any given epoch #2114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuantumExplorer
changed the title
Feat/query blocks proposed in epoch2
feat: query blocks proposed in epoch
Sep 12, 2024
QuantumExplorer
changed the title
feat: query blocks proposed in epoch
feat: query block count per Evonode proposed in any given epoch
Sep 12, 2024
lklimek
previously approved these changes
Sep 12, 2024
packages/rs-drive/src/drive/credit_pools/epochs/proposers/mod.rs
Outdated
Show resolved
Hide resolved
packages/rs-drive/src/verify/system/verify_epoch_proposers/v0/mod.rs
Outdated
Show resolved
Hide resolved
3 tasks
Hi, |
@p-m You can see an example using gRPCurl in the docs: getEvonodesProposedEpochBlocksByIds |
Thanks. It works well for epoch=7, but not for epoch<7. Here the error message with epoch=6:
|
Hi, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
As a user or a service to users, we would like to know how many blocks each proposer proposed in any given epoch.
What was done?
Added two queries, either to get this with a list of Pro_Tx_Hashes, or to get this with a range.
Epoch is an optional field, if epoch is not set, it will get the proposer block count for the current epoch.
How Has This Been Tested?
Added a few tests
Breaking Changes
Not breaking.
Checklist:
For repository code-owners and collaborators only