Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: refresh references on identity key re-enable/disable #2047

Merged
merged 11 commits into from
Aug 13, 2024

Conversation

ogabrielides
Copy link
Collaborator

@ogabrielides ogabrielides commented Aug 13, 2024

Issue being fixed or feature implemented

When disabling or re-enabling an identity key, the references pointed to that identity key are not refreshed.

What was done?

Method refresh_identity_key_reference_operations was implemented called on identity keys disable/re-enable.

How Has This Been Tested?

tests in rs-drive and rs-drive-abci

Breaking Changes

cost operations were changed.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@ogabrielides ogabrielides changed the title fix: refresh ref when re-enabling/disabling identity keys fix: refresh references when re-enabling/disabling identity keys Aug 13, 2024
@ogabrielides ogabrielides changed the title fix: refresh references when re-enabling/disabling identity keys fix!: refresh references when re-enabling/disabling identity keys Aug 13, 2024
@ogabrielides ogabrielides added this to the v1.1.0 milestone Aug 13, 2024
@ogabrielides ogabrielides marked this pull request as ready for review August 13, 2024 11:51
@ogabrielides ogabrielides changed the title fix!: refresh references when re-enabling/disabling identity keys fix!: refresh references on identity key re-enable/disable Aug 13, 2024
@QuantumExplorer QuantumExplorer merged commit eb6857b into v1.1-dev Aug 13, 2024
84 of 86 checks passed
@QuantumExplorer QuantumExplorer deleted the refresh_ref_identity_key_enable/disable branch August 13, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants