Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): asset lock quorum and core locked height verification #2030

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

lklimek
Copy link
Contributor

@lklimek lklimek commented Jul 31, 2024

Issue being fixed or feature implemented

We want to be able to check if the platform can process an asset lock.

What was done?

Added AssetLockProofVerifier trait with verify() method, implemented on AssetLockProof.

How Has This Been Tested?

Added test.

Note: Requires #2061 to pass the tests.

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@lklimek lklimek changed the title feat(sdk): asset lock quorum verify against platform fix(sdk): core chain lock is not verified before sending Jul 31, 2024
@lklimek lklimek changed the base branch from v1.0-dev to v1.1-dev July 31, 2024 10:17
@lklimek lklimek force-pushed the fix/sdk-invalid-quorum branch from 9c21078 to b3f5f17 Compare July 31, 2024 10:18
@lklimek lklimek marked this pull request as ready for review August 15, 2024 11:18
@lklimek lklimek added this to the v1.1.0 milestone Aug 16, 2024
@lklimek lklimek changed the title fix(sdk): core chain lock is not verified before sending feat(sdk): core chain lock verification against the platform Aug 16, 2024
@lklimek lklimek changed the title feat(sdk): core chain lock verification against the platform feat(sdk): asset lock quorum and core locked height verification Aug 16, 2024
@lklimek lklimek force-pushed the fix/sdk-invalid-quorum branch from a328081 to f57e455 Compare August 16, 2024 11:31

pub fn new_devnet() -> Self {
QuorumParams {
// FIXME: local devnet uses regtest
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs discussion how to handle that.

Ok(())
}
}
AssetLockProof::Instant(v) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not gonna check if we can verify signature in Drive, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have any hint how to do that client-side, I would be happy to include this here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@QuantumExplorer can you give me some formula to add it here?

@lklimek lklimek modified the milestones: v1.1.0, v1.2.0 Aug 23, 2024
@shumkov shumkov changed the base branch from v1.1-dev to master August 25, 2024 07:39
@shumkov shumkov requested a review from antouhou as a code owner August 25, 2024 07:39
@thephez thephez removed this from the v1.2.0 milestone Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants