Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashmate): status command shows tenderdash error before activation #2028

Merged
merged 7 commits into from
Jul 31, 2024

Conversation

pshenmic
Copy link
Collaborator

@pshenmic pshenmic commented Jul 31, 2024

Issue being fixed or feature implemented

Tenderdash RPC is only available after a platform activation, which will happen in 3 weeks from now. Since TD RPC is used to perform healthcheck on the service, we need to an additional check for softfork activation for the mainnet network configs.

What was done?

Added a getblockchaininfo core rpc request in the status platform command
It will only query tenderdash if the mn_rr softfork is already active.
An additional status line about platform activation time was also added.

How Has This Been Tested?

Locally

Breaking Changes

No

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@pshenmic pshenmic self-assigned this Jul 31, 2024
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shumkov shumkov merged commit 79059f6 into v1.0-dev Jul 31, 2024
22 checks passed
@shumkov shumkov deleted the fix/dashmate-platform-activation-status branch July 31, 2024 10:01
@thephez thephez added this to the v1.0.0 milestone Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants