Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashmate): a flag to keep data on reset #2026

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Jul 31, 2024

Issue being fixed or feature implemented

We should be able to reset node but keep docker volumes so we don't need to resync Core or Platform again.
This is useful during dashmate upgrade when existing dashmate had outdated docker containers.
Also haveing this you can sync a fullnode and then convert it to masternode.

What was done?

  • Added --keep-data flag to keep docker containers to the reset command

How Has This Been Tested?

Locally

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov added this to the v1.0.x milestone Jul 31, 2024
@shumkov shumkov requested a review from QuantumExplorer as a code owner July 31, 2024 06:17
Copy link
Collaborator

@pshenmic pshenmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to update documentation

@shumkov
Copy link
Member Author

shumkov commented Jul 31, 2024

I convinced @pshenmic to update the documentation in a separate PR.

@shumkov shumkov merged commit aa4c131 into v1.0-dev Jul 31, 2024
27 checks passed
@shumkov shumkov deleted the feat/dashmate/keep-data-on-reset branch July 31, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants