Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sdk to return proofs if requested #2014

Merged
merged 4 commits into from
Jul 28, 2024

Conversation

QuantumExplorer
Copy link
Member

Issue being fixed or feature implemented

Clients might want to actually see the proof.

What was done?

In this PR we add a method to give back proofs to clients if they are requested. Clients can then print out the proof to help developers debug.

How Has This Been Tested?

Breaking Changes

Not breaking.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@QuantumExplorer QuantumExplorer requested a review from shumkov as a code owner July 27, 2024 06:52
shumkov
shumkov previously approved these changes Jul 27, 2024
@QuantumExplorer QuantumExplorer merged commit 9001aa9 into v1.0-dev Jul 28, 2024
23 checks passed
@QuantumExplorer QuantumExplorer deleted the feat/SDKToReturnProofsIfRequested branch July 28, 2024 02:51
@thephez thephez added this to the v1.0.0 milestone Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants