Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(platform): core info is lost between genesis and first block #2004

Merged
merged 2 commits into from
Jul 25, 2024
Merged

fix(platform): core info is lost between genesis and first block #2004

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
62e877e
fix: core info no longer lost on first block
QuantumExplorer Jul 25, 2024
f9fe0b9
fmt
QuantumExplorer Jul 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 25 additions & 28 deletions ...ve-abci/src/execution/platform_events/core_based_updates/update_masternode_list/v0/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,36 +58,33 @@ where
core_block_height,
block_platform_state.last_committed_core_height()
);
//todo: there's a weird condition that can happen if we are not on init chain, but we are
// in the genesis and we are not on round 0, and the core height changed
if block_platform_state.last_committed_block_info().is_some() || is_init_chain {
let update_state_masternode_list_outcome::v0::UpdateStateMasternodeListOutcome {
masternode_list_diff,
removed_masternodes,
} = self.update_state_masternode_list_v0(
block_platform_state,
core_block_height,
is_init_chain,
)?;

self.update_masternode_identities(
masternode_list_diff,
&removed_masternodes,
block_info,
platform_state,
transaction,
platform_version,
)?;
let update_state_masternode_list_outcome::v0::UpdateStateMasternodeListOutcome {
masternode_list_diff,
removed_masternodes,
} = self.update_state_masternode_list_v0(
block_platform_state,
core_block_height,
is_init_chain,
)?;

if !removed_masternodes.is_empty() {
self.drive.remove_validators_proposed_app_versions(
removed_masternodes
.into_keys()
.map(|pro_tx_hash| pro_tx_hash.into()),
Some(transaction),
&platform_version.drive,
)?;
}
self.update_masternode_identities(
masternode_list_diff,
&removed_masternodes,
block_info,
platform_state,
transaction,
platform_version,
)?;

if !removed_masternodes.is_empty() {
self.drive.remove_validators_proposed_app_versions(
removed_masternodes
.into_keys()
.map(|pro_tx_hash| pro_tx_hash.into()),
Some(transaction),
&platform_version.drive,
)?;
}

Ok(())
Expand Down
Loading