Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(drive): drive and tenderdash are constantly restarting #1978

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Jul 19, 2024

Issue being fixed or feature implemented

Drive and Tenderdash containers are constantly restarting until MN_RR will be activated (hours on devnet, weeks on mainnet)

What was done?

  • Check for initial core height in a loop every 30 seconds until we get a deterministic height.

How Has This Been Tested?

None

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov requested a review from QuantumExplorer as a code owner July 19, 2024 05:58
@shumkov shumkov added this to the v1.0.0 milestone Jul 19, 2024
Copy link
Member

@QuantumExplorer QuantumExplorer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR would have the effect of making Platform not start. DO NOT MERGE.

@QuantumExplorer
Copy link
Member

While I expect there to be problems with this PR, I agreed with Ivan to merge it, and we shall see on the big tests next week.

@QuantumExplorer QuantumExplorer merged commit cd07fd4 into v1.0-dev Jul 19, 2024
23 checks passed
@QuantumExplorer QuantumExplorer deleted the fix/initit-chain-failing branch July 19, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants