Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: multiplier to version system and tests for refunds #1950

Merged
merged 7 commits into from
Jul 14, 2024

Conversation

QuantumExplorer
Copy link
Member

@QuantumExplorer QuantumExplorer commented Jul 14, 2024

Issue being fixed or feature implemented

Just some lite refactoring and adding of some tests needed to verify that fee refunds are all good.
Also fixes multiplier.

What was done?

Multiplier was moved into versioning system for now. It is now is a u64 and represents a number that when divided by 1000 gives the fractional multiplier.
We also added a lot of display functionality for easier debugging.

How Has This Been Tested?

Added tests for refunds.

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@QuantumExplorer QuantumExplorer requested a review from shumkov as a code owner July 14, 2024 18:11
Copy link
Collaborator

@ogabrielides ogabrielides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@QuantumExplorer QuantumExplorer changed the title refactor: fees to use version system3 refactor: multiplier to version system and tests for refunds Jul 14, 2024
@QuantumExplorer QuantumExplorer merged commit bb49969 into v1.0-dev-temp-fees Jul 14, 2024
2 checks passed
@QuantumExplorer QuantumExplorer deleted the refactor/FeesToUseVersionSystem3 branch July 14, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants