Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashmate): import existing Core data #1915

Merged
merged 11 commits into from
Jul 9, 2024

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Jun 28, 2024

Issue being fixed or feature implemented

Currently, most evo masternode owners run an evo masternode using only Core. We need a convenient method to import existing data and configuration so they don't need to sync and configure the node from scratch.

What was done?

  • Added a step to import Core data to dashmate setup for already registered masternodes.

How Has This Been Tested?

Running dashmate setup locally

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov added this to the v1.0.0 milestone Jun 29, 2024
@shumkov shumkov marked this pull request as ready for review June 29, 2024 00:21
@shumkov shumkov requested a review from QuantumExplorer as a code owner June 29, 2024 00:21
Copy link
Collaborator

@thephez thephez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions to consider...

Copy link
Collaborator

@thephez thephez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with the wording.
Verbage ACK 🙂

@shumkov shumkov merged commit 6632b3b into v1.0-dev Jul 9, 2024
21 checks passed
@shumkov shumkov deleted the feat/dashmate/import-core-data branch July 9, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants