refactor: multiplier to version system and tests for refunds #1950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kxcd
reviewed
Jul 14, 2024
QuantumExplorer
changed the title
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Just some lite refactoring and adding of some tests needed to verify that fee refunds are all good.
Also fixes multiplier.
What was done?
Multiplier was moved into versioning system for now. It is now is a u64 and represents a number that when divided by 1000 gives the fractional multiplier.
We also added a lot of display functionality for easier debugging.
How Has This Been Tested?
Added tests for refunds.
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only