Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: support for core 18.2 #57

Merged
merged 30 commits into from
Dec 30, 2022
Merged

feat!: support for core 18.2 #57

merged 30 commits into from
Dec 30, 2022

Conversation

shuplenkov
Copy link
Collaborator

Issue being fixed or feature implemented

Current version in incompatible with the latest core

What was done?

Introduces getWallet method which includes all wallet related methods

How Has This Been Tested?

With tests

Breaking Changes

No

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Konstantin Shuplenkov added 4 commits December 1, 2022 17:13
@shuplenkov shuplenkov marked this pull request as draft December 2, 2022 15:55
@shuplenkov shuplenkov marked this pull request as ready for review December 21, 2022 11:47
shumkov
shumkov previously approved these changes Dec 21, 2022
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@strophy
Copy link
Contributor

strophy commented Dec 23, 2022

Should we add listwallets and listwalletdir RPCs, or were these intentionally omitted?

Are there any docs associated with this repo? It is not immediately clear to me how getWallet() and setWallet() should be used, some experimentation and reading the test code is necessary.

strophy
strophy reviewed Dec 23, 2022
View reviewed changes
lib/index.js Outdated Show resolved Hide resolved
@strophy
Update lib/index.js
ebc7a24 
Co-authored-by: strophy <[email protected]>
@strophy
Copy link
Contributor

strophy commented Dec 24, 2022

Could we also add getmempoolentry so I can check for IS locks, or does this lib provide a different way of checking that?

@shuplenkov shuplenkov merged commit b3c63d6 into master Dec 30, 2022
@shuplenkov shuplenkov deleted the wallet-requests branch December 30, 2022 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strophy strophy strophy left review comments

@antouhou antouhou antouhou approved these changes

@shumkov shumkov shumkov left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shuplenkov @strophy @shumkov @antouhou