refactor: consolidate ProTx wallet UTXO locking logic #6536
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional Information
This pull request consolidates locking ProTx UTXOs in a wallet by splitting them into three steps
AddWalletUTXOs()
)ListProTxCoins()
to accept supplied sets)LockProTxCoins()
, which utilizes the previous two steps)These are the behavior changes expected from this PR:
AutoLockMasternodeCollaterals()
will now add new UTXOs it finds to the wallet UTXO set (setWalletUTXO
) (earlier behavior was to only scan and lock).LockCoin()
calls)The
m_chain
checks removed from various sections are acceptable as the check is still present inListProTxCoins()
(source) and it will clear the vector if it fails, which will effectively skip subsequent logic (also because it's the only place wherelistMNCollaterials
is called)ListProTxCoins()
is called but this isn't undesirable.Breaking Changes
None expected.
Checklist