ci: add nowallet functional tests

[knst]

Many functional tests can be run if Dash Core is built as no-wallet, but we currently do not test whether they actually work in no-wallet mode. Additionally, many functional tests can run with a simple dummy wallet, increasing the number of functional tests that can run without a wallet. However, we also do not test this scenario.

Now that extra functional tests have become available to run with the dummy-wallet MiniWallet (see #6520), we should finally add a job to our CI pipeline to run functional tests in no-wallet mode.

Though using MiniWallet for DashTestFramework to let register masternodes without using a real Dash Core wallet currently impossible due to limitation of MiniWallet:

        Note that this method fails if there is no single internal utxo
        available that can cover the cost for the amount and the fixed fee
        (the utxo with the largest value is taken).

This limitation may be addressed in future PRs, but it is out of scope for this PR.

What was done?

Add new CI job to run functional tests for nowallet.

How Has This Been Tested?

See CI: https://gitlab.com/dashpay/dash/-/jobs/8805673945

Breaking Changes

N/A

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests
• I have made corresponding changes to the documentation
• I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

[coderabbitai]

Walkthrough

The pull request introduces a new test job configuration in the .gitlab-ci.yml file for the Linux 64-bit no-wallet build target. The linux64_nowallet-test job is defined with specific characteristics, including extending predefined templates and establishing a dependency on the corresponding build job. By setting the BUILD_TARGET variable to linux64_nowallet, the job is tailored to execute tests for this specific build configuration. The modification appears to be part of a continuous integration strategy, ensuring comprehensive testing coverage for the no-wallet Linux 64-bit build variant within the project's GitLab CI/CD pipeline.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3edc738 and 1646525.

📒 Files selected for processing (1)

• .gitlab-ci.yml (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: Build Dependencies (linux64, x86_64-pc-linux-gnu)
• GitHub Check: Build Dependencies (arm-linux, arm-linux-gnueabihf)

🔇 Additional comments (1)

.gitlab-ci.yml (1)

380-388: LGTM! The job configuration looks correct.

The new test job follows the established pattern and correctly:

• Extends the test template for integration tests
• Depends on the nowallet build job
• Inherits fast mode behavior

Let's verify the job configuration and its dependencies:

✅ Verification successful

Verification successful: The nowallet test configuration is correct and complete

The entire build and test chain is properly configured:

• Base build correctly sets NO_WALLET=1
• Dependencies are properly linked
• All necessary templates are extended
• Variables are consistently configured

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the nowallet job configuration and its dependencies

# Test 1: Verify that the build dependency exists and is configured with NO_WALLET=1
echo "Checking build dependency configuration..."
rg "linux64_nowallet-build" .gitlab-ci.yml -A 5

# Test 2: Verify that the test template includes all necessary configurations
echo "Checking test template configuration..."
rg "^\.test-template:" .gitlab-ci.yml -A 20

# Test 3: Verify that no other jobs depend on this test job
echo "Checking for dependent jobs..."
rg "needs:.*linux64_nowallet-test" .gitlab-ci.yml

Length of output: 1365

---

Script:

#!/bin/bash
# Description: Additional verification of nowallet configuration

# Test 1: Check for NO_WALLET configuration
echo "Checking NO_WALLET configuration..."
rg "NO_WALLET" .gitlab-ci.yml -B 2 -A 2

# Test 2: Check x86_64-pc-linux-gnu_nowallet job configuration
echo "Checking x86_64-pc-linux-gnu_nowallet configuration..."
rg "x86_64-pc-linux-gnu_nowallet:" .gitlab-ci.yml -A 10

# Test 3: Check if there are any other nowallet configurations
echo "Checking other nowallet configurations..."
rg "nowallet" .gitlab-ci.yml

Length of output: 986

Finishing Touches

• 📝 Generate Docstrings

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[UdjinM6]

utACK 1646525

[kwvg]

utACK 1646525