revert: fix: missing changes from bitcoin#19267 - run multiprocess on CI #6195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PastaPastaPasta
changed the title
PastaPastaPasta
force-pushed
the
revert-multiproc-ci
branch
from
f15df51 to
d5a944d
Compare
|
Since this simply reverts a prior commit, and CI on this branch is happy, I'm going to merge this in |
PastaPastaPasta
added a commit
to PastaPastaPasta/dash
that referenced
this pull request
Aug 11, 2024
… run multiprocess on CI d5a944d Revert: fix: missing changes from bitcoin#19267 - run multiprocess on CI (pasta) Pull request description: ## Issue being fixed or feature implemented See dashpay#6192 for a discussion around this: for now simply make CI happy again, by not running for multiprocessor (since this is new, and unstable / dev feature, and not something shipped). ## What was done? Revert commit which reintroduces multiprocessor CI while we investigate proper fix ## How Has This Been Tested? CI ## Breaking Changes ## Checklist: _Go over all the following points, and put an `x` in all the boxes that apply._ - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ Top commit has no ACKs. Tree-SHA512: d878b02efc72019e09b09e2482e63dca276824b66272135e00ff340ba60b5b58e5f5ae3feff3b894f08958ca8fc6ce71f91c926f6aaf29a459d6230f129316f6
|
CI failed with tsan, seems as real crash. restarted just in case |
5 tasks
PastaPastaPasta
added a commit
that referenced
this pull request
Aug 12, 2024
…#22937 and ipc/process 540f687 fix: lock `::cs_main` before accessing `ChainstateManager::m_best_header` (Kittywhiskers Van Gogh) aafded6 fix: compilation error due to rebase error between bitcoin#22937 and ipc/process (Kittywhiskers Van Gogh) Pull request description: ## Issue being fixed or feature implemented CI failure for multiprocess ## What was done? It resolve compilation failure on develop (apply changes from 22937 to ipc/process) See alternate solutions: - #6192 - #6195 ## How Has This Been Tested? Run build locally: ``` make MULTIPROCESS=1 -j10 ./configure --prefix=$(pwd)/depends/x86_64-pc-linux-gnu --enable-suppress-external-warnings --enable-werror --enable-debug --enable-crash-hooks --enable-maintainer-mode --enable-stacktraces --enable-multi-process ``` ## Breaking Changes N/A ## Checklist: - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone ACKs for top commit: PastaPastaPasta: utACK 540f687 Tree-SHA512: 75b675e93763e8e53086a10b93516b8ec94418902f9be2de738517176cc835c0dad25c286426089a5327a9c13d1787b89debda2c6025cb598489204d7d5af2cf
|
It succeed now: https://gitlab.com/dashpay/dash/-/pipelines/1412133645 Super-seeded by #6199 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
See #6192 for a discussion around this: for now simply make CI happy again, by not running for multiprocessor (since this is new, and unstable / dev feature, and not something shipped).
What was done?
Revert commit which reintroduces multiprocessor CI while we investigate proper fix
How Has This Been Tested?
CI
Breaking Changes
Checklist:
Go over all the following points, and put an
xin all the boxes that apply.