Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reorder CGovernanceManager field #5550

Merged
merged 1 commit into from
Aug 29, 2023
Merged

fix: reorder CGovernanceManager field #5550

merged 1 commit into from
Aug 29, 2023

Conversation

ogabrielides
Copy link
Collaborator

@ogabrielides ogabrielides commented Aug 29, 2023 •
edited
Loading

Issue being fixed or feature implemented

When building with -Wreorder-ctor capture, the build fails with error: field 'lastMNListForVotingKeys' will be initialized after field 'votedFundingYesTriggerHash'

What was done?

Moved down votedFundingYesTriggerHash to last position in CGovernanceManager.

How Has This Been Tested?

Breaking Changes

no

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@ogabrielides ogabrielides added this to the 20 milestone Aug 29, 2023
knst
knst approved these changes Aug 29, 2023
View reviewed changes
Copy link
Collaborator

@knst knst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK (if linter is happy I am happy too)

PastaPastaPasta
PastaPastaPasta reviewed Aug 29, 2023
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for squash merge; I have compiled locally and ensured this builds and passes linter

@PastaPastaPasta PastaPastaPasta merged commit 41ddf5a into dashpay:develop Aug 29, 2023
@ogabrielides ogabrielides deleted the governance_order_ctors_fix branch August 29, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PastaPastaPasta PastaPastaPasta PastaPastaPasta approved these changes

@knst knst knst approved these changes

@UdjinM6 UdjinM6 Awaiting requested review from UdjinM6

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
20
Development

Successfully merging this pull request may close these issues.
3 participants
@ogabrielides @knst @PastaPastaPasta