qt: Fix font size and scaling issues #3734

xdustinface · 2020-09-25T16:36:46Z

This PR should fix all remaining places where the font scale wasn't applied yet (besides the splashscreen which probably also should follow anytime later). It also in general improves the font-scaling process and from now on it only updates fonts where really required. See commit messages.

@thephez This should fix all the issues you pointed out in slack
@PastaPastaPasta 64ce1b5 might fix the one you sent me. At least it makes it better here on mac where i had it similar like you with a low font scale though.
@strophy 82c1612 could be a fix for your "I can't get the same menu size like in other applications" thing

PastaPastaPasta · 2020-09-25T17:16:42Z

Stuff still getting cropped in Network traffic for me

xdustinface · 2020-09-25T21:26:56Z

@PastaPastaPasta Please look at the network traffic stats again with 3c52ea3

@PastaPastaPasta @UdjinM6 I rebased this PR now on #3717 to include 0156d4d in here as it seems to make more sense in here. Should fix the min width issue. Thoughts?

xdustinface · 2020-09-26T09:11:41Z

Okaay one more.. see the last three commits i changed it to resize depending on the font size. Now if any of the appearance attributes gets changed or if the PS UI gets shown/hidden the OptionsDialog gets resized to the required size.

UdjinM6 · 2020-09-26T13:40:44Z

Seems to be working as expected for me (could use QTimer::singleShot(0, this, SLOT(updateWidth())); instead of calling it directly in ctor to fix issues with buttons visibility not being available at that point but 3170db0 is ~~fine~~ ok-ish too :) ).

EDIT: Technically speaking though, you could one day want a visible but disabled tab there and 3170db0 won't work.

xdustinface · 2020-09-26T14:09:15Z

Seems to be working as expected for me (could use QTimer::singleShot(0, this, SLOT(updateWidth())); instead of calling it directly in ctor to fix issues with buttons visibility not being available at that point but 3170db0 is ~~fine~~ ok-ish too :) ).

Does the single shot timer 100% guaranteed only fire after the widgets visibility state flipped? I have no idea just curious.

EDIT: Technically speaking though, you could one day want a visible but disabled tab there and 3170db0 won't work.

Dropped 3170db0 and added 75f4389 that should do it better

EDIT: Forgot to include the header file into the commit hence the second force push... 🙈

UdjinM6

Does the single shot timer 100% guaranteed only fire after the widgets visibility state flipped?

Yes, this timer event should be the last one in the event queue afaik

Dropped 3170db0 and added 75f4389 that should do it better

Mostly works for me :) two suggestions, see below

src/qt/optionsdialog.cpp

src/qt/optionsdialog.h

UdjinM6 · 2020-09-26T14:54:35Z

Working as expected for me now (but I had no issues with Network traffic before, so can't say if it was also improved or not).

xdustinface · 2020-09-26T15:12:17Z

Working as expected for me now (but I had no issues with Network traffic before, so can't say if it was also improved or not).

Yeah i also had no issues with it since it was not looking bad on macOS but now it should just scale as expected based on the really required size not on the "on macOS required" size :D

Added three more commits:

d94655e + 62a6cbc To give the main window the same resizing behaviour depending on the enabled tabs like in the options window. For me on my system the 980 min width is reasonable but not sure if other systems require more there? @PastaPastaPasta how is min size looking there if PS + Masternode are hidden?

35dc39b To allow manual resizing after the window has been resized dynamically after restart/reopen or appearance adjustments.

PastaPastaPasta · 2020-09-26T19:34:43Z

Below are the only few remaining problems I could find on really edge case font settings. Don't think it's critical to get these fixed

###########################################

PastaPastaPasta

ACK

xdustinface · 2020-09-27T11:44:40Z

Two more fixes:

c5390d5 To make sure all widgets receive the font weight updates if "font-weight-normal" gets updated.

95a1698 To make sure a widget which for example had a bold font initially gets updated to normal font if requested. Like all tab-like buttons we have, the currently clicked one is bold, the others normal. Without this commit they don't update properly if the font-weight gets adjusted in appearance tab.

Those behaviours were broken by the changes of this PR, e.g. 2bfe078 and 41524ea

PastaPastaPasta

ACK

UdjinM6 · 2020-09-28T07:42:43Z

Needs rebase

To make sure non-custom context menus + QMessageBox instances createy by static calls like QMessageBox::critical are scaled also.

xdustinface · 2020-09-28T09:57:45Z

Needs rebase

Done

UdjinM6

See below + (maybe) d734bf1 + found 2 issues:

overlay and status bar font issue: start the wallet (with --regtest to have the overlay popup shown), go to Options, change font size to lowest, close, start again (everything seems normal), go to Options and change font size to the largest. Everything else is huge but not overlay and status bar texts, it's like they have some medium size font now. Restart the wallet and now they are huge too. Same works the other way around: start with huge fonts, change to tiniest (medium size for overlay and status bar again), restart (now they are tiny too).
by tweaking PS visibility and width on start we override main window geometry settings. Should either respect it somehow maybe ~~or stop saving/loading it cause it doesn't make a lot of sense otherwise.~~

EDIT: as discussed in Slack, n1 is an edge case and window geometry in n2 is still useful for window positioning, both are ok to fix them later if it's not smth trivial.

src/qt/bitcoingui.cpp

src/qt/optionsdialog.cpp

Co-authored-by: UdjinM6 <[email protected]>

PastaPastaPasta

ACK

They were scaled by font inheritance before

xdustinface · 2020-09-28T21:02:48Z

See below + (maybe) d734bf1 + found 2 issues:

In general im with you, having a smaller min size is preferable but i would rather revisit this sometimes later i tested it a bit and it breaks things with other font sizes and seems to mess a bit with traditional too.

The other commits i just added should fix the remaining scaling issues + they remove (as discussed in slack) the fixed pitch font. About the scaling: The previous default font implementation was not optimal because widgets without a object name set received an empty key from getKey(). The initial idea there was to only add the default font size for an instance of a class /UI element only once not for each instance. Now with d82c5d7 they are stored for the actual instance and removed again if the instance is not longer available in the UI. And cb23aae makes sure that there is no redundant/double scaling due to font size inheritance.

EDIT: Just noticed i didn't drop a964fe6 before i pushed. Actually i wanted to open another PR for that because it seems a bit unrelated here.. But the arg call is about font size at least so its kiiiind of related.. want me to remove it? Let me know.

PastaPastaPasta · 2020-09-28T21:17:13Z

Nah, I think a964fe6 is related enough. It's fine

PastaPastaPasta

ACK

UdjinM6

👍

ACK

* qt: Make sure font size in MasternodeList gets scaled as expected * qt: Make sure font size in ShutdownWindow gets scaled as expected * qt: Drop obsolete application font updates * qt: Scale QMenu and QMessageBox globally To make sure non-custom context menus + QMessageBox instances createy by static calls like QMessageBox::critical are scaled also. * qt: Avoid redundant scaling for tooltips and menus * qt: Only update widget's font if required * qt: Merge GUIUtil::mapFontSizeUpdates into GUIUtil::mapNormalFontUpdates * qt: Remove obsolete setFixedPitchFont call * qt: Use setFixedPitchFont in SendCoinsEntry * qt: Scale font size in increments of 0.25 * qt: Properly scale network traffic stats depending on font metrics * qt: Update min/max width of OptionsDialog depending on buttons width * qt: Emit a signal whenever any attribute of AppearanceWidget changed * qt: Update OptionsDialog width if the appearance changed * qt: Calculate the initial wide right after the window showed up Make sure the visibility state of the widgets is correct before width calculations. * qt: Call parent class showEvent + override it explicit Co-authored-by: UdjinM6 <[email protected]> * qt: Let OptionsDialog emit a signal if appearance gets changed * qt: Resize main toolbar depending on visible buttons / font attributes * qt: Reset max width after it has been set to still allow window resizing * qt: Properly update the weight of widgets with default font attributes * qt: Handle updates to the font attributes * qt: Use resize() instead of setMaximumWidth() Co-authored-by: UdjinM6 <[email protected]> * qt: Call GUIUtil::updateFonts in ModalOverlay constructor * qt: Make sure default fonts are stored properly for the related widget * qt: Ignore some low level classes in GUIUtil::updateFont * rpc: Remove obsolete `.arg()` call * qt: Drop fixedPitchFont * qt: Avoid redundant font updates. Let GUIUtil::updateFont handle them * qt: Scale recent transactions on OverviewPage They were scaled by font inheritance before * qt: Ignore QListView in GUIUtil::updateFonts

strophy · 2020-10-01T08:11:52Z

No, the problem with different size font in the menu and title bar remains. It is impossible to get them to match, and I think the reason is they are using different layout engines. The kerning looks really bad, letters have too much or not enough spacing on each side, icons in the menu are missing padding and it generally just doesn't feel "native" for Windows. I can count 6 different font sizes and weights in this screenshot alone, not counting the Dash logo...

bitterseed · 2020-10-01T09:12:37Z

Also having some scaling issues on ubuntu with a 1920x1080 display
Zooming in until my toolbar matches yours will give you a good approximation of what it looks like on my display

This issue has been around since 0.15, at which point I believe some hi-res themes were removed. I believe having 'hi-res' in the config file also causes dashcore to fail when loading

Cheers

* qt: Make sure font size in MasternodeList gets scaled as expected * qt: Make sure font size in ShutdownWindow gets scaled as expected * qt: Drop obsolete application font updates * qt: Scale QMenu and QMessageBox globally To make sure non-custom context menus + QMessageBox instances createy by static calls like QMessageBox::critical are scaled also. * qt: Avoid redundant scaling for tooltips and menus * qt: Only update widget's font if required * qt: Merge GUIUtil::mapFontSizeUpdates into GUIUtil::mapNormalFontUpdates * qt: Remove obsolete setFixedPitchFont call * qt: Use setFixedPitchFont in SendCoinsEntry * qt: Scale font size in increments of 0.25 * qt: Properly scale network traffic stats depending on font metrics * qt: Update min/max width of OptionsDialog depending on buttons width * qt: Emit a signal whenever any attribute of AppearanceWidget changed * qt: Update OptionsDialog width if the appearance changed * qt: Calculate the initial wide right after the window showed up Make sure the visibility state of the widgets is correct before width calculations. * qt: Call parent class showEvent + override it explicit Co-authored-by: UdjinM6 <[email protected]> * qt: Let OptionsDialog emit a signal if appearance gets changed * qt: Resize main toolbar depending on visible buttons / font attributes * qt: Reset max width after it has been set to still allow window resizing * qt: Properly update the weight of widgets with default font attributes * qt: Handle updates to the font attributes * qt: Use resize() instead of setMaximumWidth() Co-authored-by: UdjinM6 <[email protected]> * qt: Call GUIUtil::updateFonts in ModalOverlay constructor * qt: Make sure default fonts are stored properly for the related widget * qt: Ignore some low level classes in GUIUtil::updateFont * rpc: Remove obsolete `.arg()` call * qt: Drop fixedPitchFont * qt: Avoid redundant font updates. Let GUIUtil::updateFont handle them * qt: Scale recent transactions on OverviewPage They were scaled by font inheritance before * qt: Ignore QListView in GUIUtil::updateFonts Co-authored-by: UdjinM6 <[email protected]>

e080686 fix: don't shrink window when setting minimum width (Kittywhiskers Van Gogh) Pull request description: ## Additional Information * Closes #5886 * We've been setting restrictions on the width of the window since [dash#3734](#3734) (see d351fca and c0447b0), meaning, the behavior as described in [dash#5886](#5886) has been present since v0.16 (v0.15 and earlier used the old UI design). * We do not set any restrictions on height and in that respect, Dash Qt will behave similar to Bitcoin Qt in that it can be resized to be arbitrarily small. ## How Has This Been Tested? Crossed compiled for `x86_64-w64-mingw32` and tested resulting `dash-qt.exe` on Windows 11 22H2 (Build 22621.431). Followed reproduction steps as mentioned in [dash#5886](#5886), found width to persist even after closing Options modal using buttons and the close button on the top right. ## Breaking Changes None expected. ## Checklist: - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have added or updated relevant unit/integration/functional/e2e tests **(note: N/A)** - [x] I have made corresponding changes to the documentation **(note: N/A)** - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: PastaPastaPasta: generally utACK e080686 UdjinM6: utACK e080686 Tree-SHA512: ed3874c830c0ddf1a9e1166b75e3088969b7dfae8bca25af47045727e14a270ca2bb740e2c30b657b26a4b8e542dff8d898e5d5d2c9482d67da15578e0054632

xdustinface added this to the 16 milestone Sep 25, 2020

xdustinface added the backport-candidate-16.x label Sep 25, 2020

xdustinface force-pushed the pr-ui-fix-font-issues branch from 64ce1b5 to 0156d4d Compare September 25, 2020 21:23

xdustinface changed the title ~~qt: Fix font scaling issues~~ qt: Fix font size and scaling issues Sep 26, 2020

xdustinface force-pushed the pr-ui-fix-font-issues branch from 0156d4d to 643e52a Compare September 26, 2020 09:09

xdustinface force-pushed the pr-ui-fix-font-issues branch from 3170db0 to fe3ae7e Compare September 26, 2020 14:08

xdustinface force-pushed the pr-ui-fix-font-issues branch from fe3ae7e to 75f4389 Compare September 26, 2020 14:10

UdjinM6 reviewed Sep 26, 2020

View reviewed changes

src/qt/optionsdialog.cpp Show resolved Hide resolved

src/qt/optionsdialog.h Outdated Show resolved Hide resolved

PastaPastaPasta previously approved these changes Sep 26, 2020

View reviewed changes

xdustinface dismissed PastaPastaPasta’s stale review via 95a1698 September 27, 2020 11:38

PastaPastaPasta previously approved these changes Sep 27, 2020

View reviewed changes

xdustinface added 9 commits September 28, 2020 11:56

qt: Make sure font size in MasternodeList gets scaled as expected

d1f1c80

qt: Make sure font size in ShutdownWindow gets scaled as expected

1aa660c

qt: Drop obsolete application font updates

7440622

qt: Scale QMenu and QMessageBox globally

33b7861

To make sure non-custom context menus + QMessageBox instances createy by static calls like QMessageBox::critical are scaled also.

qt: Avoid redundant scaling for tooltips and menus

5d49661

qt: Only update widget's font if required

3ab9f20

qt: Merge GUIUtil::mapFontSizeUpdates into GUIUtil::mapNormalFontUpdates

2cb0a9a

qt: Remove obsolete setFixedPitchFont call

e689b6f

qt: Use setFixedPitchFont in SendCoinsEntry

35223e6

xdustinface dismissed PastaPastaPasta’s stale review via 78af796 September 28, 2020 09:56

xdustinface force-pushed the pr-ui-fix-font-issues branch from 95a1698 to 78af796 Compare September 28, 2020 09:56

UdjinM6 reviewed Sep 28, 2020

View reviewed changes

src/qt/bitcoingui.cpp Outdated Show resolved Hide resolved

src/qt/optionsdialog.cpp Outdated Show resolved Hide resolved

qt: Use resize() instead of setMaximumWidth()

c2395c7

Co-authored-by: UdjinM6 <[email protected]>

PastaPastaPasta previously approved these changes Sep 28, 2020

View reviewed changes

xdustinface added 7 commits September 28, 2020 21:49

qt: Call GUIUtil::updateFonts in ModalOverlay constructor

4caa74a

qt: Make sure default fonts are stored properly for the related widget

d82c5d7

qt: Ignore some low level classes in GUIUtil::updateFont

cb23aae

rpc: Remove obsolete .arg() call

a964fe6

qt: Drop fixedPitchFont

5d2854c

qt: Avoid redundant font updates. Let GUIUtil::updateFont handle them

ab6154c

qt: Scale recent transactions on OverviewPage

ab0ae5a

They were scaled by font inheritance before

xdustinface dismissed PastaPastaPasta’s stale review via ab0ae5a September 28, 2020 20:54

qt: Ignore QListView in GUIUtil::updateFonts

e364cce

PastaPastaPasta approved these changes Sep 28, 2020

View reviewed changes

xdustinface added a commit to xdustinface/dash that referenced this pull request Sep 28, 2020

qt: Fix font size and scaling issues (dashpay#3734)

2104057

UdjinM6 approved these changes Sep 28, 2020

View reviewed changes

UdjinM6 merged commit 4cb2af8 into dashpay:develop Sep 28, 2020

xdustinface added a commit to xdustinface/dash that referenced this pull request Sep 28, 2020

qt: Fix font size and scaling issues (dashpay#3734)

94894cd

xdustinface mentioned this pull request Sep 29, 2020

qt: Fix font family updates #3746

Merged

UdjinM6 removed the backport-candidate-16.x label Oct 9, 2020

kwvg mentioned this pull request Dec 9, 2024

fix: don't shrink window when setting minimum width #6471

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

qt: Fix font size and scaling issues #3734

qt: Fix font size and scaling issues #3734

xdustinface commented Sep 25, 2020

PastaPastaPasta commented Sep 25, 2020

xdustinface commented Sep 25, 2020

xdustinface commented Sep 26, 2020

UdjinM6 commented Sep 26, 2020 •

edited

Loading

xdustinface commented Sep 26, 2020 •

edited

Loading

UdjinM6 left a comment

UdjinM6 commented Sep 26, 2020

xdustinface commented Sep 26, 2020

PastaPastaPasta commented Sep 26, 2020

PastaPastaPasta left a comment

xdustinface commented Sep 27, 2020

PastaPastaPasta left a comment

UdjinM6 commented Sep 28, 2020

xdustinface commented Sep 28, 2020

UdjinM6 left a comment •

edited

Loading

PastaPastaPasta left a comment

xdustinface commented Sep 28, 2020 •

edited

Loading

PastaPastaPasta commented Sep 28, 2020 •

edited

Loading

PastaPastaPasta left a comment

UdjinM6 left a comment

strophy commented Oct 1, 2020

bitterseed commented Oct 1, 2020 •

edited

Loading

qt: Fix font size and scaling issues #3734

qt: Fix font size and scaling issues #3734

Conversation

xdustinface commented Sep 25, 2020

PastaPastaPasta commented Sep 25, 2020

xdustinface commented Sep 25, 2020

xdustinface commented Sep 26, 2020

UdjinM6 commented Sep 26, 2020 • edited Loading

xdustinface commented Sep 26, 2020 • edited Loading

UdjinM6 left a comment

Choose a reason for hiding this comment

UdjinM6 commented Sep 26, 2020

xdustinface commented Sep 26, 2020

PastaPastaPasta commented Sep 26, 2020

PastaPastaPasta left a comment

Choose a reason for hiding this comment

xdustinface commented Sep 27, 2020

PastaPastaPasta left a comment

Choose a reason for hiding this comment

UdjinM6 commented Sep 28, 2020

xdustinface commented Sep 28, 2020

UdjinM6 left a comment • edited Loading

Choose a reason for hiding this comment

PastaPastaPasta left a comment

Choose a reason for hiding this comment

xdustinface commented Sep 28, 2020 • edited Loading

PastaPastaPasta commented Sep 28, 2020 • edited Loading

PastaPastaPasta left a comment

Choose a reason for hiding this comment

UdjinM6 left a comment

Choose a reason for hiding this comment

strophy commented Oct 1, 2020

bitterseed commented Oct 1, 2020 • edited Loading

UdjinM6 commented Sep 26, 2020 •

edited

Loading

xdustinface commented Sep 26, 2020 •

edited

Loading

UdjinM6 left a comment •

edited

Loading

xdustinface commented Sep 28, 2020 •

edited

Loading

PastaPastaPasta commented Sep 28, 2020 •

edited

Loading

bitterseed commented Oct 1, 2020 •

edited

Loading