Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove a few annoying debug prints from CMasternodeMan #2179

Merged
merged 1 commit into from
Jul 12, 2018
Merged

Remove a few annoying debug prints from CMasternodeMan #2179

merged 1 commit into from
Jul 12, 2018

Conversation

codablock
Copy link

These are occurring every second and cause more noise than actual
information.

@codablock
Remove a few annoying debug prints from CMasternodeMan
c587110 
These are occurring every second and cause more noise than actual
information.
nmarley
nmarley approved these changes Jul 12, 2018
View reviewed changes
Copy link

@nmarley nmarley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Only concern would be if debugging any issues. Would it be possible to only enable this in DEBUG mode? (Note: I am not strongly attached to this outcome and generally agree with removing code/log lines if possible.)

@codablock
Copy link
Author

This is especially bugging me in debug mode as I always run my stuff with debug symbols included and "-debug=1" ;)

UdjinM6
UdjinM6 approved these changes Jul 12, 2018
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I doubt these are the most annoying or spammy one in debug=1 mode but ok :)

utACK

@UdjinM6 UdjinM6 added this to the 12.4 milestone Jul 12, 2018
@UdjinM6 UdjinM6 merged commit 23dde9f into dashpay:develop Jul 12, 2018
@codablock codablock deleted the pr_remove_masternode_logprints branch September 14, 2018 12:52
CryptoCentric pushed a commit to absolute-community/absolute that referenced this pull request Apr 25, 2019
@codablock @CryptoCentric
Remove a few annoying debug prints from CMasternodeMan (dashpay#2179)
8f60a83 
These are occurring every second and cause more noise than actual
information.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UdjinM6 UdjinM6 UdjinM6 approved these changes

@nmarley nmarley nmarley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@codablock @nmarley @UdjinM6