Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix p2pkh tests asserts #2153

Merged
merged 1 commit into from
Jun 28, 2018
Merged

Fix p2pkh tests asserts #2153

merged 1 commit into from
Jun 28, 2018

Conversation

wozniakk
Copy link

Even the results were as expected,
IsPayToPublicKeyHash() breaks at size checking step now, as was intended.
Also removes compile time array-bounds warning.

Even the results were as expected,
IsPayToPublicKeyHash() breaks at size checking step now, as was intended.
Also removes compile time array-bounds warning.
@UdjinM6 UdjinM6 added the bug label Jun 27, 2018
@UdjinM6 UdjinM6 added this to the 12.3 milestone Jun 27, 2018
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

ACK

@UdjinM6 UdjinM6 merged commit 4dbde21 into dashpay:develop Jun 28, 2018
@wozniakk wozniakk deleted the p2pkh_tests branch June 29, 2018 06:09
andvgal pushed a commit to energicryptocurrency/gen2-energi that referenced this pull request Jan 6, 2019
Even the results were as expected,
IsPayToPublicKeyHash() breaks at size checking step now, as was intended.
Also removes compile time array-bounds warning.
CryptoCentric pushed a commit to absolute-community/absolute that referenced this pull request Mar 7, 2019
Even the results were as expected,
IsPayToPublicKeyHash() breaks at size checking step now, as was intended.
Also removes compile time array-bounds warning.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants