Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.12.3 #2145

Merged
merged 1 commit into from
Jun 24, 2018
Merged

Release 0.12.3 #2145

merged 1 commit into from
Jun 24, 2018

Conversation

UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Jun 24, 2018

CLIENT_VERSION_IS_RELEASE: false->true

CLIENT_VERSION_IS_RELEASE false->true
@UdjinM6 UdjinM6 added this to the 12.3 milestone Jun 24, 2018
Copy link

@codablock codablock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@UdjinM6 UdjinM6 merged commit 9af9d57 into dashpay:develop Jun 24, 2018
@UdjinM6 UdjinM6 mentioned this pull request Jun 24, 2018
@nmarley
Copy link

nmarley commented Jun 24, 2018

@UdjinM6 Will this need to be changed back after the release? If so, this seems like a good candidate for a release-x.x style branch instead which goes into master but then don't merge that back into develop.

@UdjinM6
Copy link
Author

UdjinM6 commented Jun 24, 2018

@nmarley after #2142 and 12.3 tag I'll copy develop to v0.12.3.x and push it. Then we should be able to switch this back to false together with version bump to 12.4 in develop and also backport fixes to v0.12.3.x from develop if any.

@UdjinM6 UdjinM6 deleted the release123 branch November 26, 2020 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants