Fix typos and rpc help text #2120
Conversation
src/wallet/rpcwallet.cpp
Outdated
| @@ -1304,7 +1304,7 @@ UniValue listreceivedbyaddress(const JSONRPCRequest& request) | |||
| if (request.fHelp || request.params.size() > 4) | |||
| throw std::runtime_error( | |||
| "listreceivedbyaddress ( minconf addlockconf include_empty include_watchonly)\n" | |||
| "\nList balances by receiving address.\n" | |||
| "\nList recieves by receiving address.\n" | |||
There was a problem hiding this comment.
Actually, did this need to be changed? It does list the balance by address, right?
There was a problem hiding this comment.
I agree, I'm not sure "List receives by ..." makes sense (at least not to me).
There was a problem hiding this comment.
I think this matches what it does. What do you guys think?
"List transactions received by an address."
There was a problem hiding this comment.
Wait, so it's not specifying the tx outpoint, meaning if you get this list, then it's up to you to query the transaction and determine which output(s) paid to the address?
I'm also curious how confirmations is used here... is this the number of confirmations of the latest transaction with some number of outputs which pays out to this address?
There was a problem hiding this comment.
@nmarley Yes, that sounds correct. And the confirmation count is for the latest tx. I finally looked it up on this super helpful site 😆
There was a problem hiding this comment.
Ok, well whatever sounds good to you then. Seems like a funny call which only points in the right direction instead of serving fully useful info, but that's another issue entirely.
There was a problem hiding this comment.
Maybe List incoming payments grouped by receiving address and List incoming payments grouped by account? Should be clear enough.
There was a problem hiding this comment.
👍 Sounds okay to me. That describes what they do.
Shame on me
src/rpc/rawtransaction.cpp
Outdated
| @@ -882,7 +882,7 @@ UniValue sendrawtransaction(const JSONRPCRequest& request) | |||
| "1. \"hexstring\" (string, required) The hex string of the raw transaction)\n" | |||
| "2. allowhighfees (boolean, optional, default=false) Allow high fees\n" | |||
| "3. instantsend (boolean, optional, default=false) Use InstantSend to send this transaction\n" | |||
| "3. bypasslimits (boolean, optional, default=false) Bypass transactions policy limits\n" | |||
| "4. bypasslimits (boolean, optional, default=false) Bypass transactions policy limits\n" | |||
There was a problem hiding this comment.
nit - "Bypass transaction policy limits".
Maybe? 🙂
* Fix typo in PS info dialog Also adjust translations accordingly. * Fix typo in PS low key warning * Fix typo in sendrawtransaction help * Fix sendtoaddress/sendmany help text * Fix listreceivedby* help text * Fix typo in listunspent help * Fix spelling "recieves"->"receives" Shame on me * transactions->transaction * receives->"incoming payments grouped"
Cleanup only, no functionality/actual code changes.
Changes:
If you know of any other similar things, pls leave your comment below, let's collect them all here and fix at once.