-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare v0.12.2.2 release notes #1769
Conversation
d8853d4
to
2a4dd3b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See in-line comments for minor stuff.
doc/release-notes.md
Outdated
@@ -20,361 +22,179 @@ How to Upgrade | |||
If you are running an older version, shut it down. Wait until it has completely | |||
shut down (which might take a few minutes for older versions), then run the | |||
installer (on Windows) or just copy over /Applications/Dash-Qt (on Mac) or | |||
dashd/dash-qt (on Linux). | |||
dashd/dash-qt (on Linux). Because of per-UTXO fix (see below) there is a | |||
one-time database upgrade operation, so expect a slightly longer first run. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because of the per-UTXO fix (see below) there is a one-time database upgrade operation, so expect a slightly longer startup time on first run.
doc/release-notes.md
Outdated
|
||
Because release 0.12.2.2 includes per-UTXO fix (see below) which changes the | ||
structure of the internal database, this release is not backwards compatible. | ||
You will have to reindex database if you decide to use previous version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because release 0.12.2.2 includes the per-UTXO fix (see below), which changes the
structure of the internal database, this release is not fully backwards compatible.
You will have to reindex the database if you decide to use the previous version.
doc/release-notes.md
Outdated
demonstrated this summer on Вrеаkіng Віtсоіn Соnfеrеnсе іn Раrіs. The DoS can | ||
cause nodes to allocate excessive amounts of memory, which leads them to a halt. | ||
You can read more about the fix in the original Bitcoin Core pull request | ||
https://github.com/bitcoin/bitcoin/pull/10195 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes a potential vulnerability, so called 'Corebleed', which was
demonstrated this summer on the Вrеаkіng Віtсоіn Соnfеrеnсе іn Раrіs. ...
doc/release-notes.md
Outdated
All transaction fees are reduced 10x (from 10K per Kb to 1K per Kb), including fees for InstantSend (from 0.001 DASH per input to 0.0001 per input) | ||
To fix this issue in Dash Core however, we had to backport a lot of other | ||
improvements from Bitcoin Core, see full list of backports in the detailed | ||
change log below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changelog (no space)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about this one, both forms are legit imo e.g. https://www.gnu.org/prep/standards/html_node/Change-Logs.html but http://keepachangelog.com/en/1.0.0/
Addressed review comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
…on and a general note about typos/refactoring etc.
ACK |
* 'spice' of github.com:NarubyRiverlione/spice: (8382 commits) updated testnet genessis spice images more rename genesis blocks ports magic message letters start letter addresses cleanup : * remove gitian signatures * remove seeds rename: more originale files rename Prepare 0.12.2.3 release notes (dashpay#1846) Avoid reference leakage in CKeyHolderStorage::AddKey (dashpay#1840) Protect CKeyHolderStorage via mutex (dashpay#1834) Skip existing masternode conections on mixing (dashpay#1833) Merge pull request dashpay#1836 from lodgepole/feature/backport-11847 Fix -liquidityprovider option (dashpay#1829) Vote on IS only if it was accepted to mempool (dashpay#1826) bump version to 0.12.2.3 (dashpay#1827) Merge bitcoin#8256: BUG: bitcoin-qt crash Swap iterations and fUseInstantSend parameters in ApproximateBestSubset (dashpay#1819) Fix crash on exit when -createwalletbackups=0 (dashpay#1810) Prepare v0.12.2.2 release notes (dashpay#1769) Force rcc to use resource format version 1. (dashpay#1784) ... # Conflicts: # contrib/gitian-descriptors/gitian-osx-signer.yml # contrib/gitian-descriptors/gitian-win-signer.yml # src/chainparams.cpp # src/qt/res/icons/bitcoin.icns # src/qt/res/icons/bitcoin.ico # src/qt/res/icons/bitcoin.png # src/qt/res/icons/crownium/about.png # src/qt/res/icons/drkblue/about.png # src/qt/res/icons/drkblue/bitcoin.png # src/qt/res/icons/light/about.png # src/qt/res/icons/light/remove.png # src/qt/res/icons/remove.png # src/qt/res/icons/trad/about.png # src/qt/res/icons/trad/remove.png
Note: the link
https://github.com/dashpay/dash/compare/v0.12.2.1...dashpay:v0.12.2.2
mentioned in change log section will become available after release tag, current set of changes - v0.12.2.1...dashpay:develop