fix: fix previous commit with fixes

dashpay · Oct 6, 2023 · d83dbd2 · d83dbd2
1 parent 5e31bd5
commit d83dbd2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/evo/mnhftx.cpp b/src/evo/mnhftx.cpp
@@ -159,7 +159,7 @@ bool CMNHFManager::ProcessBlock(const CBlock& block, const CBlockIndex* const pi
         }
         Signals signals = GetSignalsStage(pindex->pprev);
         if (new_signals.empty()) {
-            if (fJustCheck) {
+            if (!fJustCheck) {
                 AddToCache(signals, pindex);
             }
             return true;

diff --git a/test/functional/feature_mnehf.py b/test/functional/feature_mnehf.py
@@ -103,9 +103,9 @@ def check_fork(self, expected):
 
     def ensure_tx_is_not_mined(self, tx_id):
         try:
-            assert_equal(self.nodes[0].getrawtransaction(tx_id, 1)['height'], -1);
+            assert_equal(self.nodes[0].getrawtransaction(tx_id, 1)['height'], -1)
             raise AssertionError("Transaction should not be mined")
-        except KeyError as e:
+        except KeyError:
             # KeyError is expected
             pass
 
@@ -249,7 +249,7 @@ def run_test(self):
         assert_equal(get_bip9_details(node, 'testdummy')['status'], 'defined')
 
         self.log.info("Testing EHF signal with same bit")
-        self.log.info(f"Previous signal at height={ehf_height}, total blocks={node.getblockcount()}, should success at {ehf_hight + 576}")
+        self.log.info(f"Previous signal at height={ehf_height}, total blocks={node.getblockcount()}, should success at {ehf_height + 576}")
         self.slowly_generate_batch(576 - (node.getblockcount() - ehf_height) - 1)
         ehf_tx_sent = self.send_tx(ehf_tx_second)
         self.log.info("Mine block and ensure not mined yet...")