merge bitcoin#26553: Fix intermittent failure in rpc_net.py

dashpay · Oct 16, 2024 · 1bf135b · 1bf135b
1 parent 5bf245b
commit 1bf135b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/test/functional/rpc_net.py b/test/functional/rpc_net.py
@@ -114,7 +114,7 @@ def test_getpeerinfo(self):
         no_version_peer_id = 3
         no_version_peer_conntime = self.mocktime
         with self.nodes[0].assert_debug_log([f"Added connection peer={no_version_peer_id}"]):
-            self.nodes[0].add_p2p_connection(P2PInterface(), send_version=False, wait_for_verack=False)
+            no_version_peer = self.nodes[0].add_p2p_connection(P2PInterface(), send_version=False, wait_for_verack=False)
         peer_info = self.nodes[0].getpeerinfo()[no_version_peer_id]
         peer_info.pop("addr")
         peer_info.pop("addrbind")
@@ -155,7 +155,8 @@ def test_getpeerinfo(self):
                 "version": 0,
             },
         )
-        self.nodes[0].disconnect_p2ps()
+        no_version_peer.peer_disconnect()
+        self.wait_until(lambda: len(self.nodes[0].getpeerinfo()) == 3)
 
     def test_getnettotals(self):
         self.log.info("Test getnettotals")

diff --git a/test/functional/test_framework/test_node.py b/test/functional/test_framework/test_node.py
@@ -682,7 +682,8 @@ def num_test_p2p_connections(self):
         return len([peer for peer in self.getpeerinfo() if P2P_SUBVERSION % "" in peer['subver']])
 
     def disconnect_p2ps(self):
-        """Close all p2p connections to the node."""
+        """Close all p2p connections to the node.
+        Use only after each p2p has sent a version message to ensure the wait works."""
         for p in self.p2ps:
             p.peer_disconnect()