Skip to content
This repository has been archived by the owner on Dec 16, 2021. It is now read-only.

fix: platform sync shows Infinity% #281

Merged
merged 1 commit into from
Mar 3, 2021
Merged

Conversation

strophy
Copy link
Contributor

@strophy strophy commented Feb 23, 2021

This PR fixes a display error in the status and status:platform commands now that an external block explorer is available.

Issue being fixed or feature implemented

The status and status:platform commands would show Infinity% remaining sync when no external source of the final platform block height was available.

What was done?

Added a URL to an external platform block explorer (thanks cloudwheels for setting this up)

How Has This Been Tested?

Tested while syncing platform on testnet.

Breaking Changes

Why did package-lock.json get updated? Does this break anything?

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shumkov shumkov merged commit a40140b into v0.18-dev Mar 3, 2021
@shumkov shumkov deleted the fix-platform-sync-status branch March 3, 2021 14:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants