feat: restart command #152
Conversation
|
|
||
| if (isMinerEnabled === true && config.get('network') !== NETWORKS.LOCAL) { | ||
| this.error(`'core.miner.enabled' option supposed to work only with local network. Your network is ${config.get('network')}`, { exit: true }); |
There was a problem hiding this comment.
In the context of command (this), we should use this.error method. Everything was fine here.
There was a problem hiding this comment.
I changed it because it wasn't working, did you test it? Here is my output on testnet with miner enabled:
# with this.error()
strophy@X250:~/Code/mn-bootstrap$ mn start
✖ this.error is not a function
# with throw new Error()
strophy@X250:~/Code/mn-bootstrap$ mn start
✖ 'core.miner.enabled' option only works with local network. Your network is testnet.
How do I find out what the current context is? It's impossible to console.log(this) because of listr overwriting any console output, and the debugger shows Error but not error as a function of this, so I still don't know what this actually refers to.
There was a problem hiding this comment.
Oh... my bad. This is the context of listr task too since it's in startNodeTask what we pass to Listr as a task :).
You can understand the context usually just by reading the code. If it's not clear you can run the command with debugger. In WebStorm it's easy. Just add a Node.JS run configuration with bin/mn as a start file and pass reset as application params.
| @@ -58,7 +70,7 @@ function startNodeTaskFactory(dockerCompose) { | |||
|
|
|||
| if (driveImageBuildPath || dapiImageBuildPath) { | |||
| if (config.get('network') === NETWORKS.TESTNET) { | |||
| this.error('You can\'t use drive-image-build-path and dapi-image-build-path options with testnet network', { exit: true }); | |||
| throw new Error('You can\'t use drive-image-build-path and dapi-image-build-path options with testnet network', { exit: true }); | |||
There was a problem hiding this comment.
Error constructor accepts filename as the second param. You don't need to pass anything except message (the first argument)
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error/Error
There was a problem hiding this comment.
Fixed, is there a way to see the parameters required by a function in the IDE? I can't get this working in VS Code because using awilix seems to break the "Go to definition" function for all injected functions.
There was a problem hiding this comment.
Hm... it works in WebStorm. You can use something like "go to function" feature by the function name.
This PR implements the
restartcommand described in #68Issue being fixed or feature implemented
Now that the config command was implemented in #119, the config state is stored on disk. This allows us to restart a node with a single command, running updated code or config on restart.
What was done?
My approach here was just to combine the stop and start commands in a single new command. Oclif allows you to call commands programmatically, but I'm not sure if this is a good idea here, given we would just be passing the same arguments around anyway.
How Has This Been Tested?
Breaking Changes
Checklist:
For repository code-owners and collaborators only