Skip to content
This repository has been archived by the owner on Dec 16, 2021. It is now read-only.

feat: replace env files and presets with dynamic configs #119

Merged
merged 46 commits into from
Aug 14, 2020

Conversation

strophy
Copy link
Contributor

@strophy strophy commented Aug 11, 2020

Adds a config command to persist config state across sessions. See #61

Issue being fixed or feature implemented

It is currently necessary to specify which network is being used in every single command. This feature stores the config state on disk and provides a number of interfaces with which to manage the configuration.

What was done?

  • Described Config and ConfigCollection classes
  • Added ConfigRepostitory and read/write logic on command start/end
  • Added basic commands for managing configuration
  • Implemented config validation
  • Removed dotenv files and pass envs to Docker Compose directly
  • Data and config dirs depend on network name
  • Getting data from configs if options are missing and storing command results in config

How Has This Been Tested?

Manually

Breaking Changes

When complete, this will change the way each command is issued

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov added this to the v0.15 milestone Aug 11, 2020
@shumkov shumkov changed the title [WIP] feat: config command feat: config command Aug 11, 2020
@shumkov shumkov changed the title feat: config command feat: replace env files to dynamic configs Aug 12, 2020
@shumkov shumkov changed the title feat: replace env files to dynamic configs feat: replace env files and presets with dynamic configs Aug 13, 2020
@shumkov shumkov marked this pull request as ready for review August 13, 2020 15:42
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 👍

@shumkov shumkov merged commit 46cfd01 into dashevo:v0.15-dev Aug 14, 2020
@shumkov shumkov deleted the config branch August 14, 2020 10:22
@strophy strophy mentioned this pull request Aug 21, 2020
7 tasks
@strophy strophy mentioned this pull request Oct 8, 2020
7 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants