Switch to nimble_ownership
#148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Dec 26, 2023
lib/mox/server.ex
Outdated
| @@ -44,14 +44,16 @@ defmodule Mox.Server do | |||
| # Callbacks | |||
|
|
|||
| def init(:ok) do | |||
| {:ok, os} = NimbleOwnership.start_link([]) | |||
There was a problem hiding this comment.
Shouldn't we start it on mox supervision tree with a given name? 🤔
josevalim
reviewed
Dec 26, 2023
lib/mox/server.ex
Outdated
| state = maybe_revalidate_lazy_calls(lazy_calls, state) | ||
| owner_pid = | ||
| case NimbleOwnership.get_owner(state.os, caller_pids, mock) do | ||
| %{owner_pid: owner_pid} -> owner_pid |
There was a problem hiding this comment.
Can the owner_pid be nil? If not, shouldn't we merge the conditional below into this function?
josevalim
reviewed
Dec 26, 2023
josevalim
approved these changes
Jan 11, 2024
whatyouhide
force-pushed
the
al/nimble-ownership
branch
from
bd39ee4 to
f953af4
Compare
|
@josevalim done with global mode and no more process in |
|
I think we should totally remove the server, if there is no need. :) |
|
@josevalim ok, 200 lines less and removed |
josevalim
reviewed
Jan 20, 2024
lib/mox.ex
Outdated
| case N.fetch_owner(@ownership_server, [owner_pid], mock, @timeout) do | ||
| {tag, ^owner_pid} when tag in [:ok, :shared_owner] -> :ok | ||
| {:shared_owner, other_owner} -> throw({:error, {:not_shared_owner, other_owner}}) | ||
| {:ok, other_owner} -> throw({:error, {:currently_allowed, other_owner}}) |
There was a problem hiding this comment.
Let's not use throw? If we encapsulate this into a private function, using with should be straight-forward.
josevalim
reviewed
Jan 20, 2024
lib/mox.ex
Outdated
| case N.fetch_owner(@ownership_server, caller_pids, mock, @timeout) do | ||
| {tag, owner_pid} when tag in [:shared_owner, :ok] -> owner_pid | ||
| :error -> throw(:no_expectation) | ||
| end |
josevalim
reviewed
Jan 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP, we need to publish a new version of nimble_ownership 🙃