Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create and delete resource class #218

Merged
merged 24 commits into from
Aug 6, 2020
Merged

Conversation

kilchenmann
Copy link
Contributor

@kilchenmann kilchenmann commented Jul 14, 2020

https://dasch.myjetbrains.com/youtrack/issue/DSP-427

Two new methods to create and delete resource classes.
Needs knora-api v13.0.0-rc.11

The e2e test can be reproduced in test-framework; open console to see responses:

  • Click on Login
  • Optional: Click on Get anything project ontologies → Anything project should have 3 ontologies
  • Click on Create testonto → Will add a test onto to anything project
  • Optional: Click on Get anything project ontologies → Anything project should now have 4 ontologies
  • Click on Get testonto → Test onto doesn't have a class
  • Click on Create resource class → Will add resource class to test onto
  • Click on Get testonto → Test onto should have a test res class
  • Click on Delete resource class
  • Click on Get testonto → Test onto doesn't have a class anymore
  • Click on Delete testonto
  • Optional: Click on Get anything project ontologies → Anything project should again have 3 ontologies

@kilchenmann kilchenmann self-assigned this Jul 14, 2020
@kilchenmann kilchenmann added the enhancement Improve existing code or new feature label Jul 14, 2020
@kilchenmann kilchenmann marked this pull request as draft July 14, 2020 19:51
@kilchenmann kilchenmann marked this pull request as ready for review July 31, 2020 15:52
Copy link
Contributor

@flavens flavens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tests and the test app work
In the code, some imports should be cleaned up and alphabetised.

@kilchenmann
Copy link
Contributor Author

In the code, some imports should be cleaned up and alphabetised.

Done in 353dcb4 and 0e6c389

@kilchenmann kilchenmann requested a review from mdelez August 5, 2020 08:01
Copy link
Contributor

@mdelez mdelez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I went through the steps outlined in the PR description and everything worked

@kilchenmann kilchenmann requested review from flavens and mdelez August 5, 2020 21:43
@kilchenmann
Copy link
Contributor Author

@flavens @mdelez I had to update some small details. Tobias asked for these changes. They are all part of 112115e. Can you take a second look?

@mdelez
Copy link
Contributor

mdelez commented Aug 6, 2020

@flavens @mdelez I had to update some small details. Tobias asked for these changes. They are all part of 112115e. Can you take a second look?

Everything still works for me :) My approval is still valid

@kilchenmann kilchenmann merged commit 62c022e into master Aug 6, 2020
@kilchenmann kilchenmann deleted the wip/dsp-427-create-res-class branch August 6, 2020 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing code or new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants