-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create and delete resource class #218
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tests and the test app work
In the code, some imports should be cleaned up and alphabetised.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I went through the steps outlined in the PR description and everything worked
https://dasch.myjetbrains.com/youtrack/issue/DSP-427
Two new methods to create and delete resource classes.
Needs knora-api v13.0.0-rc.11
The e2e test can be reproduced in test-framework; open console to see responses:
Login
Get anything project ontologies
→ Anything project should have 3 ontologiesCreate testonto
→ Will add a test onto to anything projectGet anything project ontologies
→ Anything project should now have 4 ontologiesGet testonto
→ Test onto doesn't have a classCreate resource class
→ Will add resource class to test ontoGet testonto
→ Test onto should have a test res classDelete resource class
Get testonto
→ Test onto doesn't have a class anymoreDelete testonto
Get anything project ontologies
→ Anything project should again have 3 ontologies