Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename package #191

Merged
merged 4 commits into from
May 29, 2020
Merged

Rename package #191

merged 4 commits into from
May 29, 2020

Conversation

kilchenmann
Copy link
Contributor

This PR renames the package from @knora/api to @dasch-swiss/dsp-js
Resolves DSP-224

@kilchenmann kilchenmann added the breaking breaking change in the public API label May 28, 2020
@kilchenmann kilchenmann self-assigned this May 28, 2020
@kilchenmann kilchenmann requested review from tobiasschweizer and subotic and removed request for subotic and tobiasschweizer May 28, 2020 16:18
@kilchenmann kilchenmann changed the title Rename the package Rename package May 28, 2020
@tobiasschweizer
Copy link
Contributor

@kilchenmann Thanks for this PR!

Could we try setting up an automated publication process before doing the renaming? Just in case we screw up a few times, this would still go in the old @knora/api.

@kilchenmann
Copy link
Contributor Author

Could we try setting up an automated publication process before doing the renaming? Just in case we screw up a few times, this would still go in the old @knora/api.

Yes this is planned (DSP-302). I thought to do it after this PR to not screw up the old npm package @knora/api.

@tobiasschweizer
Copy link
Contributor

I thought to do it after this PR to not screw up the old npm package @knora/api.

:-) So we are going to screw up anyway ... the question is just where it hurts the least ;-)

@kilchenmann
Copy link
Contributor Author

the question is just where it hurts the least ;-)

I thought the new one. Because it doesn't exist yet. Nobody knows it. So if there's a mistake, no one will know about it. And we can reverse the publication.

@tobiasschweizer
Copy link
Contributor

I thought the new one. Because it doesn't exist yet. Nobody knows it. So if there's a mistake, no one will know about it. And we can reverse the publication.

Sounds fair!

However, we couldn't use the same version again:

Once a package is unpublished, it cannot be republished. If you’ve unpublished a package by mistake, we’d recommend publishing again under a different name, or for unpublished versions, bumping the version number and publishing again.

https://docs.npmjs.com/unpublishing-packages-from-the-registry#when-to-unpublish

So I guess we could just start with 0.0.1-rc.0 or something like this.

@tobiasschweizer
Copy link
Contributor

I will briefly test this PR locally.

@kilchenmann
Copy link
Contributor Author

So I guess we could just start with 0.0.1-rc.0 or something like this.

Yes, good point.

Copy link
Contributor

@tobiasschweizer tobiasschweizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, looks good!

Could we work on the automated publication next week or so? We still need to figure out what to do about the dev package including test data that we need for development of UI lib but don't need in production.

@kilchenmann
Copy link
Contributor Author

Could we work on the automated publication next week or so? We still need to figure out what to do about the dev package including test data that we need for development of UI lib but don't need in production.

Yes, I thought I needed your help anyway. Especially with the dev package. It's planned for Sprint-6.

@tobiasschweizer
Copy link
Contributor

Yes, I thought I needed your help anyway. Especially with the dev package. It's planned for Sprint-6.

And I need your help. Sounds like a good match :-)

Copy link
Contributor

@subotic subotic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks :-)

@kilchenmann kilchenmann merged commit 7c38e54 into master May 29, 2020
@kilchenmann kilchenmann deleted the wip/dsp-224-from-knora-to-dasch-swiss branch May 29, 2020 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking breaking change in the public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants