-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename package #191
Rename package #191
Conversation
@kilchenmann Thanks for this PR! Could we try setting up an automated publication process before doing the renaming? Just in case we screw up a few times, this would still go in the old @knora/api. |
Yes this is planned (DSP-302). I thought to do it after this PR to not screw up the old npm package @knora/api. |
:-) So we are going to screw up anyway ... the question is just where it hurts the least ;-) |
I thought the new one. Because it doesn't exist yet. Nobody knows it. So if there's a mistake, no one will know about it. And we can reverse the publication. |
Sounds fair! However, we couldn't use the same version again:
https://docs.npmjs.com/unpublishing-packages-from-the-registry#when-to-unpublish So I guess we could just start with 0.0.1-rc.0 or something like this. |
I will briefly test this PR locally. |
Yes, good point. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, looks good!
Could we work on the automated publication next week or so? We still need to figure out what to do about the dev package including test data that we need for development of UI lib but don't need in production.
Yes, I thought I needed your help anyway. Especially with the dev package. It's planned for Sprint-6. |
And I need your help. Sounds like a good match :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks :-)
This PR renames the package from @knora/api to @dasch-swiss/dsp-js
Resolves DSP-224