Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup legacy and unused (DEV-4368) #1891

Merged
merged 6 commits into from
Nov 27, 2024
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions apps/dsp-app/src/styles.scss
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,9 @@
@use "styles/viewer";
@use "styles/ontology";

/* TODO(mdc-migration): Remove legacy-core once all legacy components are migrated*/
@include mat.legacy-core();
@include mat.core();

// Include all typography configurations for the components (now separate from mat.core())
/* TODO(mdc-migration): Remove all-legacy-component-typographies once all legacy components are migrated*/
@include mat.all-legacy-component-typographies();
@include mat.all-component-typographies(t.$dsp-typography-config);

// Define the color palettes for the theme.
Expand All @@ -34,8 +30,6 @@ $theme: mat.define-light-theme((
));

// Include all theme styles for the components.
/* TODO(mdc-migration): Remove all-legacy-component-themes once all legacy components are migrated*/
@include mat.all-legacy-component-themes($theme);
@include mat.all-component-themes($theme);


Expand Down Expand Up @@ -210,4 +204,4 @@ button.space-reducer {

.mat-mdc-dialog-content { //prevent horizontal scrollbar in dialog
overflow-x: hidden !important;
}
}
37 changes: 0 additions & 37 deletions apps/dsp-app/src/styles/_layout.scss
Original file line number Diff line number Diff line change
Expand Up @@ -250,40 +250,3 @@
.inline {
display: inline-flex;
}

// --------------------------------------

// ?-?-?-?-?-?-?-?-?-?-?-?-?-?-?-?-?-?-
// TODO: clean up the following classes
// ?-?-?-?-?-?-?-?-?-?-?-?-?-?-?-?-?-?-

.flex-panel {
display: flex !important;
}

// font sizes

.smaller {
font-size: small;
}

//
// dialog: not the one from material, it's a fullframe dialog box
.window.fullframe {
position: absolute;
z-index: 100;
top: 0;
width: 100vw;
height: 100vh;
background: white;
}

// --------------------------------------

//
// color
.transparent {
background: none;
}

// --------------------------------------
148 changes: 0 additions & 148 deletions apps/dsp-app/src/styles/_viewer.scss
Original file line number Diff line number Diff line change
@@ -1,81 +1,6 @@
// css for parent value components
@use 'config' as *;

.read-mode-view {
font: 400 15px/24px sans-serif;

.show-comment {
color: $dark-text;

.mat-icon {
font-size: 18px;
display: inline;
vertical-align: text-bottom;
}
}

.rm-value,
.rm-comment {
display: block;
margin: 0px;
}

.rm-comment {
margin-top: 6px;
font-size: small;
border-top: 1px solid rgba(33, 33, 33, 0.1);
}

.rm-value.text-value {
white-space: pre-wrap;
}

.rm-value.list:has(.hierarchy:only-child) .last {
font-weight: normal;
}

.rm-value.list,
.rm-value .hierarchy {
display: inline-flex;

.last {
font-weight: bold;
}
}
}

.child-value-component,
.value-component-comment {
display: block !important;

textarea.mat-mdc-input-element.cdk-textarea-autosize {
resize: vertical;
}
}

.parent-component-wrapper .value-component-comment {
margin-top: -2em;
}

.parent-value-component
.child-value-component
.mat-mdc-form-field-wrapper
.mat-mdc-form-field-infix {
border-top: 0em solid transparent;
}

// css for child components of a parent value component

.child-input-component {
display: inline-block;
vertical-align: bottom;
width: 49%;
}

.child-input-component.full-width {
width: 100%;
}

// custom error message

.custom-error-message {
Expand All @@ -84,86 +9,13 @@
padding-bottom: 1em;
}

// viewer operations

.grid-container {
display: grid;
grid-template-columns: 80% 20%;
grid-template-rows: auto auto;
}

.value-component,
.crud-buttons {
vertical-align: top;
}

.value-component {
grid-row-start: 1;
grid-row-end: auto;
grid-column-start: 1;
grid-column-end: 2;
position: relative;
}

.value-component.hover {
background-color: #f5f5f5;
}

.value-component.highlight {
background-color: #f4f400;
}

.crud-buttons {
grid-row-start: 1;
grid-row-end: auto;
grid-column-start: 2;
grid-column-end: 3;
display: inline-flex;
}

.value-action {
.material-icons,
.mat-icon {
font-size: 18px;
height: 18px;
width: 18px;
}
}

.mat-mdc-form-field-error {
grid-row-start: 1;
grid-row-end: auto;
grid-column-start: 3;
grid-column-end: end;
}

.deletion-dialog .title {
font-weight: bold;
font-size: 18px;
text-align: center;
}

.deletion-dialog .action-buttons {
float: right;

.cancel {
padding: 0 16px;
}
}

.deletion-dialog-message {
font-size: 16px;
background-color: #ededf5;
border: 1px solid #d8d8df;
border-radius: 5px;
padding: 20px 10px 20px 10px;
text-align: center;
}

.deletion-dialog-message .deletion-comment {
min-width: 80%;
}

.ck-content code {
font-family: monospace !important;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ export interface DeleteResourceDialogProps {
<textarea
data-cy="app-delete-resource-dialog-comment"
matInput
class="deletion-comment"
type="text"
[(ngModel)]="comment"
[placeholder]="'Ex. Resource was created by mistake...'"></textarea>
Expand Down
Loading