Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staking new era and slash validators fixing #94

Merged
merged 5 commits into from
Nov 18, 2019

Conversation

hackfisher
Copy link
Contributor

Not finished yet.

  • new_era
  • slash_validator
  • CurrencyToVote
  • remove duplicated phragmen

return;
/// This is called :
/// - Immediately when an account's balance falls below existential deposit.
/// - after a `withdraw_unbond()` call that frees all of a stash's bonded balance.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

withdraw_unbond was removed in #92. Reserve?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to reserve, if #92 is merged first, this PR will do the merging and resolve conflicts.

@hackfisher hackfisher merged commit 18a3e00 into develop Nov 18, 2019
@AurevoirXavier
Copy link
Member

cargo build in srml/staking

error: cannot find macro `vec` in this scope
   --> /Users/xavier/.cargo/git/checkouts/substrate-a7fa553ead635512/d2c4b0d/core/phragmen/src/lib.rs:272:40
    |
272 |         let mut assignment = (n.who.clone(), vec![]);
    |                                              ^^^

error: aborting due to previous error

error: could not compile `substrate-phragmen`.
warning: build failed, waiting for other jobs to finish...
error: build failed

hackfisher added a commit that referenced this pull request Nov 19, 2019
@hackfisher hackfisher deleted the denny_staking_fixing branch November 22, 2019 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants