Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add: treasury #287

Merged
merged 3 commits into from
Feb 25, 2020
Merged

add: treasury #287

merged 3 commits into from
Feb 25, 2020

Conversation

AurevoirXavier
Copy link
Member

No description provided.

@AurevoirXavier
Copy link
Member Author

fix #264
todo #285

@AurevoirXavier AurevoirXavier linked an issue Feb 24, 2020 that may be closed by this pull request
Support Treasury Module #264
Closed
hackfisher
hackfisher approved these changes Feb 25, 2020
View reviewed changes
bin/node/runtime/src/lib.rs
type RingCurrency = Balances;
type KtonCurrency = Kton;
type ApproveOrigin = pallet_collective::EnsureMembers<_4, AccountId, CouncilCollective>;
type RejectOrigin = pallet_collective::EnsureMembers<_2, AccountId, CouncilCollective>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Polkadot Codebase are using EnsureProportion, might be more suitable for production?

Another question, how the council get elected?

	type ApproveOrigin = collective::EnsureProportionAtLeast<_3, _5, AccountId, CouncilCollective>;
	type RejectOrigin = collective::EnsureProportionMoreThan<_1, _2, AccountId, CouncilCollective>;

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/paritytech/substrate/blob/master/frame/collective/src/lib.rs#L20

elect through https://github.com/paritytech/substrate/blob/master/frame/elections-phragmen/src/lib.rs

@hackfisher hackfisher merged commit f48b4fc into darwinia-network:develop Feb 25, 2020
boundless-forest pushed a commit that referenced this pull request Aug 1, 2023
@sorpaas
Upgrade evm to 0.23 (#287)
b4ce6ec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hackfisher hackfisher hackfisher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Treasury Module
2 participants
@AurevoirXavier @hackfisher