Auto claim unstaking #1010
Merged
Auto claim unstaking #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hackfisher
reviewed
Mar 10, 2023
AurevoirXavier
force-pushed
the
xavier/unstaking
branch
from
e9ff11c
to
6376ec0
Compare
Signed-off-by: Xavier Lau <[email protected]>
AurevoirXavier
force-pushed
the
xavier/unstaking
branch
from
6376ec0
to
62cf5e4
Compare
|
@boundless-forest please also help review this. |
hackfisher
reviewed
Mar 10, 2023
| @@ -456,7 +456,13 @@ pub mod pallet { | |||
| ); | |||
| } | |||
|
|
|||
| let now = <frame_system::Pallet<T>>::block_number(); | |||
|
|
|||
| l.unstaking_ring.retain(|(_, t)| t > &now); | |||
There was a problem hiding this comment.
wait, where do the removed unstaking_ring go? not in free right?
There was a problem hiding this comment.
OK, so free includes staked and unstaking, deposits.
There was a problem hiding this comment.
The unstaking part belong to the user now. It'll transfer to the staking_pot account later.
There was a problem hiding this comment.
I am not so sure that it should be t > &now or t >= &now here?
boundless-forest
approved these changes
Mar 10, 2023
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto claim unstaking if it is expired while migrating.