Convert the rest locations to H160 by hashing it (#138)

* Convert the rest locations to H160 by hashing it * format * fix review
darwinia-network · Dec 20, 2022 · ba6a50c · ba6a50c
1 parent 02b2ccb
commit ba6a50c
Show file tree

Hide file tree

Showing 6 changed files with 45 additions and 4 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/runtime/common/Cargo.toml b/runtime/common/Cargo.toml
@@ -10,6 +10,9 @@ repository  = "https://github.com/darwinia-network/darwinia"
 version     = "6.0.0"
 
 [dependencies]
+# crates.io
+codec = { package = "parity-scale-codec", version = "3.2", default-features = false }
+
 # darwinia
 dc-primitives = { default-features = false, path = "../../core/primitives" }
 
@@ -21,13 +24,18 @@ xcm          = { default-features = false, git = "https://github.com/paritytech/
 xcm-executor = { default-features = false, git = "https://github.com/paritytech/polkadot", branch = "release-v0.9.30" }
 
 # substrate
-frame-support     = { default-features = false, git = "https://github.com/paritytech/substrate", branch = "polkadot-v0.9.30" }
-frame-system      = { default-features = false, git = "https://github.com/paritytech/substrate", branch = "polkadot-v0.9.30" }
-pallet-collective = { default-features = false, git = "https://github.com/paritytech/substrate", branch = "polkadot-v0.9.30" }
+frame-support      = { default-features = false, git = "https://github.com/paritytech/substrate", branch = "polkadot-v0.9.30" }
+frame-system       = { default-features = false, git = "https://github.com/paritytech/substrate", branch = "polkadot-v0.9.30" }
+pallet-collective  = { default-features = false, git = "https://github.com/paritytech/substrate", branch = "polkadot-v0.9.30" }
+sp-io              = { default-features = false, git = "https://github.com/paritytech/substrate", branch = "polkadot-v0.9.30" }
+sp-std             = { default-features = false, git = "https://github.com/paritytech/substrate", branch = "polkadot-v0.9.30" }
 
 [features]
 default = ["std"]
 std = [
+	# crates.io
+	"codec/std",
+
 	# darwinia
 	"dc-primitives/std",
 
@@ -39,4 +47,6 @@ std = [
 	"frame-support/std",
 	"frame-system/std",
 	"pallet-collective/std",
+	"sp-io/std",
+	"sp-std/std",
 ]
diff --git a/runtime/common/src/xcm_configs.rs b/runtime/common/src/xcm_configs.rs
@@ -18,13 +18,17 @@
 
 // core
 use core::marker::PhantomData;
+// crates.io
+use codec::Encode;
 // darwinia
 use dc_primitives::GWEI;
 // polkadot
 use xcm::latest::{prelude::*, Weight as XCMWeight};
-use xcm_executor::traits::ShouldExecute;
+use xcm_executor::traits::{Convert, ShouldExecute};
 // substrate
 use frame_support::{log, traits::ConstU128};
+use sp_io::hashing::blake2_256;
+use sp_std::borrow::Borrow;
 
 /// Base balance required for the XCM unit weight.
 pub type XcmBaseWeightFee = ConstU128<GWEI>;
@@ -104,3 +108,21 @@ impl ShouldExecute for DenyReserveTransferToRelayChain {
 		Ok(())
 	}
 }
+
+/// Struct that converts a given MultiLocation into a 20 bytes account id by hashing
+/// with blake2_256 and taking the first 20 bytes
+pub struct Account20Hash<AccountId>(PhantomData<AccountId>);
+impl<AccountId: From<[u8; 20]> + Into<[u8; 20]> + Clone> Convert<MultiLocation, AccountId>
+	for Account20Hash<AccountId>
+{
+	fn convert_ref(location: impl Borrow<MultiLocation>) -> Result<AccountId, ()> {
+		let hash: [u8; 32] = ("multiloc", location.borrow()).borrow().using_encoded(blake2_256);
+		let mut account_id = [0u8; 20];
+		account_id.copy_from_slice(&hash[0..20]);
+		Ok(account_id.into())
+	}
+
+	fn reverse_ref(_: impl Borrow<AccountId>) -> Result<MultiLocation, ()> {
+		Err(())
+	}
+}
diff --git a/runtime/crab/src/pallets/polkadot_xcm.rs b/runtime/crab/src/pallets/polkadot_xcm.rs
@@ -47,6 +47,8 @@ pub type LocationToAccountId = (
 	xcm_builder::SiblingParachainConvertsVia<polkadot_parachain::primitives::Sibling, AccountId>,
 	// Straight up local `AccountId20` origins just alias directly to `AccountId`.
 	xcm_builder::AccountKey20Aliases<RelayNetwork, AccountId>,
+	// The rest of locations are converted via hashing it.
+	darwinia_common_runtime::xcm_configs::Account20Hash<AccountId>,
 );
 /// This is the type we use to convert an (incoming) XCM origin into a local `Origin` instance,
 /// ready for dispatching a transaction with Xcm's `Transact`. There is an `OriginKind` which can

diff --git a/runtime/darwinia/src/pallets/polkadot_xcm.rs b/runtime/darwinia/src/pallets/polkadot_xcm.rs
@@ -47,6 +47,8 @@ pub type LocationToAccountId = (
 	xcm_builder::SiblingParachainConvertsVia<polkadot_parachain::primitives::Sibling, AccountId>,
 	// Straight up local `AccountId20` origins just alias directly to `AccountId`.
 	xcm_builder::AccountKey20Aliases<RelayNetwork, AccountId>,
+	// The rest of locations are converted via hashing it.
+	darwinia_common_runtime::xcm_configs::Account20Hash<AccountId>,
 );
 /// This is the type we use to convert an (incoming) XCM origin into a local `Origin` instance,
 /// ready for dispatching a transaction with Xcm's `Transact`. There is an `OriginKind` which can

diff --git a/runtime/pangolin/src/pallets/polkadot_xcm.rs b/runtime/pangolin/src/pallets/polkadot_xcm.rs
@@ -47,6 +47,8 @@ pub type LocationToAccountId = (
 	xcm_builder::SiblingParachainConvertsVia<polkadot_parachain::primitives::Sibling, AccountId>,
 	// Straight up local `AccountId20` origins just alias directly to `AccountId`.
 	xcm_builder::AccountKey20Aliases<RelayNetwork, AccountId>,
+	// The rest of locations are converted via hashing it.
+	darwinia_common_runtime::xcm_configs::Account20Hash<AccountId>,
 );
 /// This is the type we use to convert an (incoming) XCM origin into a local `Origin` instance,
 /// ready for dispatching a transaction with Xcm's `Transact`. There is an `OriginKind` which can