Skip to content

Commit

Permalink
install package prior to running github tests
Browse files Browse the repository at this point in the history
  • Loading branch information
ablack3 committed Jan 16, 2024
1 parent 3bf64f7 commit 1b8968a
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 14 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/postgres-test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,6 @@ jobs:
shell: Rscript {0}

- name: Run tests on postgres with RPostgres driver
run: R -e 'withr::with_envvar(new = c("CI_TEST_DB" = "postgres"), testthat::test_local())'
run: R -e 'devtools::install(); withr::with_envvar(new = c("CI_TEST_DB" = "postgres"), testthat::test_local())'


16 changes: 8 additions & 8 deletions tests/testthat/setup.R
Original file line number Diff line number Diff line change
Expand Up @@ -166,15 +166,15 @@ ciTestDbs <- c("duckdb", "postgres", "redshift", "sqlserver", "snowflake")
if (Sys.getenv("CI_TEST_DB") == "") {

dbToTest <- c(
"duckdb"
,
# "duckdb"
# ,
"postgres"
,
"redshift"
,
"sqlserver"
,
"snowflake"
# ,
# "redshift"
# ,
# "sqlserver"
# ,
# "snowflake"
# ,
# "spark"
)
Expand Down
5 changes: 0 additions & 5 deletions tests/testthat/test-db-generateConceptCohortSet.R
Original file line number Diff line number Diff line change
@@ -1,9 +1,4 @@
test_generate_concept_cohort_set <- function(con, cdm_schema, write_schema) {
# if (dbms(con) == "bigquery") return(skip("failing test"))

if (dbms(con) == "bigquery") {
return(skip("failing test"))
}

# withr::local_options("CDMConnector.cohort_as_temp" = FALSE) # temp cohort tables are not implemented yet
cdm <- cdm_from_con(con,
Expand Down

0 comments on commit 1b8968a

Please sign in to comment.