-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Markers into Nodes #692
Conversation
Reviewed 20 of 43 files at r1, 1 of 1 files at r2, 4 of 4 files at r4. dart/dynamics/BodyNode.h, line 614 [r3] (raw file): Comments from Reviewable |
Conflicts: dart/dynamics/BodyNode.cpp dart/dynamics/BodyNode.h dart/dynamics/Skeleton.cpp dart/dynamics/Skeleton.h
Review status: 2 of 16 files reviewed at latest revision, 1 unresolved discussion. dart/dynamics/BodyNode.h, line 614 [r3] (raw file): Comments from Reviewable |
Reviewed 14 of 19 files at r5, 4 of 4 files at r6. Comments from Reviewable |
Up until now, Markers have been managed separately from Nodes, because Markers predate the Node concept in DART. This PR changes Markers into a Node type so that it shares all the same machinery as Nodes instead of having its own machinery.
Note that this PR builds off of #691
This change is