Improvements to ReferentialSkeleton #557
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is in response to issues #548 and #556. This fixes the issue where BodyNodes with zero-dof parent Joints will be left out of ReferentialSkeletons, and it allows users to add and remove BodyNodes and DegreesOfFreedom from Groups freely (i.e. without any coupling between BodyNodes and their parent DegreesOfFreedom).
However, in the current implementation there is still a 1-to-1 correspondence between BodyNodes and Joints, even though BodyNodes are decoupled from DegreesOfFreedom. What this means is that
ReferentialSkeleton::getJoint(i)
is always equivalent toReferentialSkeleton::getBodyNode(i)->getParentJoint()
. This is despite the fact that there is no coupling betweenReferentialSkeleton::getBodyNode(~)
andReferentialSkeleton::getDof(~)
.So I before this pull request can be considered finished, I'd like to pose the question: Should
getBodyNode(~)
be decoupled fromgetJoint(~)
forReferentialSkeleton
s, or is the current setup okay as it is?I should also note that this pull request introduces a few changes to the behavior of the API of the
Group
class as a consequence of the decoupling. I hope that this does not result in any headaches for the existing users ofGroup
.