Feedback on #461 #506
Merged
Feedback on #461 #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ART[Core]Config.cmake.in
… and use override specifier
…ct with Configuration class
| include("${CURRENT_DIR}/DARTTargets.cmake") | ||
|
|
||
| # Retrun absolute path of the library instead of just library name as |
…ve unnecessary empty line
| else | ||
| return 1; | ||
| template <typename T> inline constexpr | ||
| int sgn(T x, std::false_type) |
There was a problem hiding this comment.
I think my personal preference would be to name the function sign, because it only adds one letter and makes the purpose of the function completely obvious (whereas sgn could be an acronym for something else).
That being said, I don't object to using sgn.
There was a problem hiding this comment.
I considered to change it to signum with similar reason but just put it off. sign seems more clear and neat one than signum. I will change it to sign and deprecate sgn.
|
The changes look good. I also compiled and tested each of the osg examples, and they're all still working just fine. 👍 |
|
Thanks! Merging this to the original branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.