You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request removes the CPack commands from CMakeLists.txt and the auto.sh shell script. From talking to @mxgrey and @jslee02, it sounds like these are outdated and are no longer used to build Debian packages.
I thought it would be best to remove them since they led me on a bit of a wild goose chase while trying to build DART into a .deb. If anyone is using them, then please feel free to close this pull request.
I'm not using cpack to build Debian packages since Launchpad requires to build source using debuild, and I would like to remove outdated and no one using code in general. However, I'm not sure keeping codes for cpack is totally useless (under assumption we update them). Jose (@j-rivero), who is the build engineer of OSRF, might have some idea on this.
For using debbuild we don't need the CPack support. I don't know the history of these scripts in the DART code base but sounds to me like they were using some time ago to generate .deb packages manually in the same box. I agree that if they are outdated, it is better to remove the support than keep them floating around unsupported. +1.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes the
CPackcommands fromCMakeLists.txtand theauto.shshell script. From talking to @mxgrey and @jslee02, it sounds like these are outdated and are no longer used to build Debian packages.I thought it would be best to remove them since they led me on a bit of a wild goose chase while trying to build DART into a
.deb. If anyone is using them, then please feel free to close this pull request.