Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop supporting FCL < 0.5 #1647

Merged
merged 2 commits into from
Jan 14, 2022
Merged

Drop supporting FCL < 0.5 #1647

merged 2 commits into from
Jan 14, 2022

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Jan 14, 2022 •
edited
Loading

Before creating a pull request

  • Document new methods and classes
  • Format new code files using ClangFormat by running make format
  • Build with -DDART_TREAT_WARNINGS_AS_ERRORS=ON and resolve all the compile warnings

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change
  • Add Python bindings for new methods and classes

@jslee02 jslee02 added this to the DART 6.13.0 milestone Jan 14, 2022
@jslee02 jslee02 marked this pull request as ready for review January 14, 2022 23:12
@jslee02 jslee02 merged commit 2a158b1 into main Jan 14, 2022
@jslee02 jslee02 deleted the dep_versions branch January 14, 2022 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
DART 6.13.0
Development

Successfully merging this pull request may close these issues.
1 participant
@jslee02