Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default options to DartLoader for missing properties in URDF files #1605

Merged
merged 2 commits into from
Sep 19, 2021

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Sep 18, 2021

Enable to pass parsing options to DartLoader. Currently the options are default resource retriever, default root joint type, and default inertia of link. The default inertia options is to resolve #1604.


Before creating a pull request

  • Document new methods and classes
  • Format new code files using clang-format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@jslee02 jslee02 added this to the DART 6.12.0 milestone Sep 18, 2021
@jslee02 jslee02 mentioned this pull request Sep 18, 2021
2 tasks
@codecov
Copy link

codecov bot commented Sep 18, 2021

Codecov Report

Merging #1605 (7b2a635) into main (552f8d1) will decrease coverage by 0.03%.
The diff coverage is 60.13%.

@@            Coverage Diff             @@
##             main    #1605      +/-   ##
==========================================
- Coverage   59.05%   59.02%   -0.04%     
==========================================
  Files         473      473              
  Lines       39727    39808      +81     
==========================================
+ Hits        23462    23495      +33     
- Misses      16265    16313      +48     
Impacted Files Coverage Δ
dart/utils/urdf/DartLoader.cpp 66.66% <44.44%> (-10.29%) ⬇️
python/dartpy/utils/DartLoader.cpp 82.81% <82.53%> (+16.85%) ⬆️

@jslee02 jslee02 marked this pull request as ready for review September 18, 2021 21:29
@jslee02 jslee02 merged commit 3b1f079 into main Sep 19, 2021
@jslee02 jslee02 deleted the issue_1604 branch September 19, 2021 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default Inertia mass equal to 1kg
1 participant