Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with clang-cl #1509

Merged
merged 4 commits into from
Oct 14, 2020
Merged

Fix compatibility with clang-cl #1509

merged 4 commits into from
Oct 14, 2020

Conversation

traversaro
Copy link
Contributor

clang-cl is the Visual Studio-compatible version of clang (https://clang.llvm.org/docs/MSVCCompatibility.html).
This PR:

  • Enables compilation of DART even for VS < 2019 if Clang is used (as clang-cl can be perfectly C++14 compatible even if the used MSVC version is not)
  • Avoid to pass the /MP option to clang-cl that does not support it
  • Adds a GitHub Actions job to compile DART with clang-cl (using in particular the ClangCl toolset shipped with MSVC)

If you use the clang-cl compiler you can have a full compliant C++14
compiler even when using VS2017 .
clang-cl does not support the /MP option
@traversaro traversaro changed the title Fix compatibilty with clang-cl Fix compatibility with clang-cl Oct 12, 2020
@codecov
Copy link

codecov bot commented Oct 12, 2020

Codecov Report

Merging #1509 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1509      +/-   ##
==========================================
- Coverage   58.18%   58.17%   -0.02%     
==========================================
  Files         414      414              
  Lines       30008    30008              
==========================================
- Hits        17459    17456       -3     
- Misses      12549    12552       +3     
Impacted Files Coverage Δ
dart/dynamics/Skeleton.cpp 66.22% <0.00%> (-0.17%) ⬇️

.github/workflows/ccpp.yml Outdated Show resolved Hide resolved
@traversaro
Copy link
Contributor Author

The macOS failure seem to be related to actions/runner-images#1811 .

@jslee02
Copy link
Member

jslee02 commented Oct 14, 2020

The macOS failure seem to be related to actions/virtual-environments#1811 .

It seems this build failure is unrelated to this PR. It'd make sense to fix in a separate CR.

@jslee02 jslee02 merged commit 46abc66 into dartsim:master Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants