Change dartpy install command to make install-dartpy #1503
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, DART provided two build modes, which is controlled by
DART_BUILD_DARTPY
: (1) build for the C++ package (as either shared or static libraries) or (2) build for the Python package (i.e.dartpy
) enforcing to build the C++ libraries as static libraries. When installing the package, (1) installs the C++ headers and shared/static libraries while (b) only the binding module (i.e.,dartpy.so
). So we had to configure and build the package to build for both the C++ package and Python package.However, there is a use case that requires to build
dartpy
against the shared libraries or/and build both the C++ and Python libraries without reconfiguring the package. This PR (i) removes the enforcement of static library build fordartpy
and (ii) allows us to builddartpy
without reconfiguring. For (ii), we still need to setDART_BUILD_DARTPY
asON
though.In short, here is the old behavior:
and the following is the new behavior:
Before creating a pull request
Before merging a pull request
CHANGELOG.md