Support IN_LIST operator in DARTConfig.cmake (6.9 backport) #1494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The IN_LIST keyword in DARTFindBullet caused a configuration error in gazebo10. Setting CMP0057 to new should prevent similar problems in downstream packages.
jslee02
requested changes
Aug 30, 2020
cmake/DARTFindBullet.cmake
Outdated
| @@ -12,6 +12,7 @@ | |||
| find_package(Bullet COMPONENTS BulletMath BulletCollision MODULE QUIET) | |||
|
|
|||
| if((BULLET_FOUND OR Bullet_FOUND) AND NOT TARGET Bullet) | |||
| cmake_policy(SET CMP0057 NEW) | |||
There was a problem hiding this comment.
The error could occur anywhere IN_LIST is used. Also, this policy setting isn't necessary if the required CMake version is set from the parent project (e.g., gazebo). This policy setting isn't required if the required CMake version is set to 3.5.1 or greater. Let's fix this in DARTConfig.cmake.in like this one.
There was a problem hiding this comment.
ok, I'll copy that approach here
Codecov Report
@@ Coverage Diff @@
## release-6.9 #1494 +/- ##
===============================================
+ Coverage 57.02% 57.03% +0.01%
===============================================
Files 366 366
Lines 27147 27147
===============================================
+ Hits 15481 15484 +3
+ Misses 11666 11663 -3
|
scpeters
changed the title
jslee02
approved these changes
Aug 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In DART 6.9.3, the
IN_LISTkeyword in DARTFindBullet caused a configuration error in gazebo10 (see gazebosim/gazebo-classic#2835). SettingCMP0057to new should prevent similar problems in downstream packages.Before creating a pull request
clang-formatBefore merging a pull request
CHANGELOG.md