Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pybind eigen header to dartpy DistanceResult #1480

Merged
merged 3 commits into from
Aug 5, 2020

Conversation

balakumar-s
Copy link
Contributor

@balakumar-s balakumar-s commented Aug 4, 2020

Adding pybind/eigen.h to allow read/write of eigen types in DistanceResult

Without including the pybind/eigen header, readwrite of eigen types is not possible.
@codecov
Copy link

codecov bot commented Aug 4, 2020

Codecov Report

Merging #1480 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1480   +/-   ##
=======================================
  Coverage   58.05%   58.05%           
=======================================
  Files         414      414           
  Lines       30004    30004           
=======================================
  Hits        17419    17419           
  Misses      12585    12585           

Copy link
Member

@jslee02 jslee02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix!

@jslee02 jslee02 merged commit e84d236 into dartsim:master Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants