Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for parsing root joint type without world link #1399

Merged
merged 4 commits into from
Aug 17, 2019

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Aug 16, 2019

The root joint type cannot be specified when the URDF doesn't contain "world" link. In that case, the URDF parser in DART assumes the root joint type as "free" joint, but some user could expect it to be "fixed" joint.

This PR makes that behavior configurable using flags.


Before creating a pull request

  • Document new methods and classes
  • Format new code files using clang-format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@jslee02 jslee02 added this to the DART 6.10.0 milestone Aug 16, 2019
@codecov
Copy link

codecov bot commented Aug 16, 2019

Codecov Report

Merging #1399 into master will increase coverage by 0.03%.
The diff coverage is 83.33%.

@@            Coverage Diff            @@
##           master   #1399      +/-   ##
=========================================
+ Coverage   57.27%   57.3%   +0.03%     
=========================================
  Files         366     366              
  Lines       27432   27442      +10     
=========================================
+ Hits        15711   15726      +15     
+ Misses      11721   11716       -5
Impacted Files Coverage Δ
dart/utils/urdf/DartLoader.hpp 100% <ø> (ø) ⬆️
dart/dynamics/SharedLibraryIkFast.cpp 49.41% <0%> (ø) ⬆️
dart/utils/urdf/DartLoader.cpp 78.83% <89.28%> (+0.74%) ⬆️
dart/dynamics/WeldJoint.cpp 86.66% <0%> (+16.66%) ⬆️

@jslee02 jslee02 merged commit 7b8cb9e into master Aug 17, 2019
@jslee02 jslee02 deleted the feature/urdf_parser branch August 17, 2019 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant